Skip to content

Loading…

Inline Editing in Bookmarks App #397

Merged
merged 4 commits into from

5 participants

@raghunayyar
ownCloud member

The title and the link in one line and the description along with the buttons in the second line. Fixes #159

Thanks.

@eMerzh eMerzh was assigned
@jancborchardt
ownCloud member

The buttons stay absolute even when you click another bookmark to edit, and in some cases are thus not clickable because they are overlayed by the bookmark rows. It’s a bit weird to explain, best try it yourself in Chrome @raghunayyar.

raghunayyar Removed Absolute Positioning of the cancel/submit buttons.
They take up the third row, keeping them on the right side with screens
with low resolution might not be a good idea.
d7f9fb1
@owncloud-bot

Can one of the admins verify this patch?

@eMerzh
ownCloud member

@jancborchardt by inline did you mean "with no edit vs select mode" like in contact? or just make the form a little more "in the flow" ?
I'm not really convinced ... @raghunayyar did you try to edit then scroll? the layout seems.... messy ... can't really explain....

what do you guys think ?

@raghunayyar
ownCloud member

@eMerzh I am so sorry, I missed this particular test case before implementing it. Will add more changes to this PR only.

@jancborchardt
ownCloud member

@eMerzh @raghunayyar definitely not like in Contacts. Bookmarks have a way smaller detail view than contacts, so it’s not the same. The layout just needs to be a bit better, what about:
One line for: Title Address Tags
Second line for: Description [Save]

Save button should be made obsolete through automatically saving a field onblur (or ~500ms of no change, whatever comes first). The save button right now has a second effect which is »collapse this entry again« – when the save button is gone there should be a downward pointing triangle on the top right instead, which can be clicked to collapse that entry.

@raghunayyar
ownCloud member

@jancborchardt and @eMerzh I needed to clarify a couple of things, I have added title address tags in one line. Ok, it's fine. But when I have more than say 5-6 tags, then what? Should I make the hight fixed and scroll the next tags 'within' the tag bar, earlier tags being an entirely different line, there was never an issue about this. Let me know about this.

Thanks!!

@jancborchardt
ownCloud member

@raghunayyar Yes, height fixed and tags scrolling should do it.

@DeepDiver1975
ownCloud member

@owncloud-bot this is ok to test

@eMerzh
ownCloud member

@raghunayyar a scroll or smth for the tag and it's ok for me :)

@raghunayyar
ownCloud member

@eMerzh It is already there, I have fixed the width so that as soon as the tag's first line gets filled it scrolls to the second line with a scroll bar present. Working for me on Firefox and Chrome both. Please let me know.

@eMerzh
ownCloud member

Ah ok sorry ...

it works for me on chromium but not on firefox ... i have the scrolling capability but i can't see the scroll bars....
trying to look why...

@raghunayyar
ownCloud member

@eMerzh the reason is in ff for a height defined below a 'certain value' the scrollbar doesn't get visible. So, I had to change the look by increasing the tags textarea height. I couldn't find any other solution. Now it works just fine on my Chrome and FF. Please let me know if it is fine.

@eMerzh eMerzh merged commit 46f2c98 into owncloud:master

1 check passed

Details default Merged build finished.
@eMerzh
ownCloud member

Thanksn merged ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 25, 2012
  1. Inline Bookmark Editing

    raghunayyar committed
Commits on Jan 1, 2013
  1. Removed Absolute Positioning of the cancel/submit buttons.

    raghunayyar committed
    They take up the third row, keeping them on the right side with screens
    with low resolution might not be a good idea.
Commits on Jan 11, 2013
Commits on Jan 28, 2013
This page is out of date. Refresh to see the latest.
Showing with 25 additions and 0 deletions.
  1. +25 −0 bookmarks/css/bookmarks.css
View
25 bookmarks/css/bookmarks.css
@@ -291,6 +291,30 @@ li:hover em { display : none; }
.bookmark_single:hover .bookmark_url a[href]{ color:gray; }
.bookmark_url { display: none; }
+.bookmark_form_title {
+ float: left;
+ width:25%;
+}
+
+.bookmark_form_url {
+ float:left;
+ width:25%;
+}
+
+.bookmark_form_tags {
+ width:30%;
+ float:left;
+}
+
+
+.bookmark_form_desc {
+ width:50%;
+}
+
+.bookmark_form_desc textarea {
+ margin-top:-3.4em;
+}
+
.bookmark_form_title input, .bookmark_form_url input, .bookmark_form_desc textarea {
width: 80%;
}
@@ -305,6 +329,7 @@ li:hover em { display : none; }
width: 80%;
box-shadow: 0 1px 1px #FFFFFF, 0 1px 0 #BBBBBB inset;
margin: 3px;
+ height:6.4em;
}
.bm_view_img .bookmark_actions {
bottom: 0.7em;
Something went wrong with that request. Please try again.