New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling MP3 files #734 #870

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@vobornik

vobornik commented Mar 25, 2013

The code does not make sense to me:

$file = \OC\Files\Filesystem::getView()->getAbsolutePath($path); // relative to www root!
$data = @$this->getID3->analyze('oc://' . $file);                // analyze() cannot recognize 'oc://' prefix

I corrected it to (I double checked - it works for me):

$file = \OC\Files\Filesystem::getLocalFile($path); // get local file name from $path
$data = @$this->getID3->analyze($file);            // analyze that file
@wolf-kapa

This comment has been minimized.

Show comment
Hide comment
@wolf-kapa

wolf-kapa Mar 26, 2013

👍 All over sudden my media app finds media files in S3 folders...

wolf-kapa commented Mar 26, 2013

👍 All over sudden my media app finds media files in S3 folders...

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo

VicDeo Mar 27, 2013

Member

@icewind1991 I've seen a dozen of such reports. Is stream required here?

Member

VicDeo commented Mar 27, 2013

@icewind1991 I've seen a dozen of such reports. Is stream required here?

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo

VicDeo Mar 28, 2013

Member

@vobornik 'oc://' is used to retrieve files through the stream wrapper.
It's needed to index/play files from the external storage.
It works for me without patch (Nginx/php-fpm 5.4.12)

please check if http://www.php.net/manual/en/filesystem.configuration.php#ini.allow-url-fopen
is enabled in your php.ini

Member

VicDeo commented Mar 28, 2013

@vobornik 'oc://' is used to retrieve files through the stream wrapper.
It's needed to index/play files from the external storage.
It works for me without patch (Nginx/php-fpm 5.4.12)

please check if http://www.php.net/manual/en/filesystem.configuration.php#ini.allow-url-fopen
is enabled in your php.ini

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo

VicDeo Mar 29, 2013

Member

Should be alreadyfixed with 53cc464

Member

VicDeo commented Mar 29, 2013

Should be alreadyfixed with 53cc464

@VicDeo VicDeo closed this Mar 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment