Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise version in appstore to 1.0 #308

Closed
ghost opened this issue Mar 10, 2016 · 21 comments
Closed

Raise version in appstore to 1.0 #308

ghost opened this issue Mar 10, 2016 · 21 comments
Labels

Comments

@ghost
Copy link

@ghost ghost commented Mar 10, 2016

Hi,

currently https://apps.owncloud.com/content/show.php/Calendar?content=168707 has the version 0.6.7 set however the download for oC 9.0 contains version 1.0.

Because of that the calendar will shop up with the version 0.6.7 within the oC internal appstore even if 1.0 is installed.

@georgehrke georgehrke added the question label Mar 10, 2016
@georgehrke
Copy link
Contributor

@georgehrke georgehrke commented Mar 10, 2016

That's an issue in the App Store. The lowest available version (for 8.0) is 0.6.7

@georgehrke
Copy link
Contributor

@georgehrke georgehrke commented Mar 10, 2016

Not sure what do you about this :/

@georgehrke
Copy link
Contributor

@georgehrke georgehrke commented Mar 10, 2016

edit _app_apps_owncloud_com_safari__today_at_1_43_59_pm

The issue is related to this field. I could simply swap Content file 1 and Content file 4, but then ownCloud 8 would show 1.0 even though it's just 0.6.7.

@georgehrke
Copy link
Contributor

@georgehrke georgehrke commented Mar 10, 2016

@ghost
Copy link
Author

@ghost ghost commented Mar 10, 2016

Ah, i see the issue there. Wasn't are how this is configured within the appstore.

Contacts for example is using the highest version 1.0.0.0 at https://apps.owncloud.com/content/show.php/Contacts?content=168708

@georgehrke
Copy link
Contributor

@georgehrke georgehrke commented Mar 10, 2016

Yes, this is how it looks for the contacts app:
contacts

@georgehrke
Copy link
Contributor

@georgehrke georgehrke commented Mar 10, 2016

Swapping it would probably be the easiest, although I think this should be properly fixed in core

@ghost
Copy link
Author

@ghost ghost commented Mar 10, 2016

Yes, i agree that this is rather something which should be fixed in core.

@georgehrke
Copy link
Contributor

@georgehrke georgehrke commented Mar 10, 2016

@RealRancor Could you open an issue there please? :)

@aspdye
Copy link

@aspdye aspdye commented Mar 10, 2016

What have the contacts guys made different - they are also providing multiple versions for 8.0, 8.1, 8.2 and 9.0 and App Store is showing up 1.0.0.0 😕

@Henni @jancborchardt @georgehrke

@georgehrke
Copy link
Contributor

@georgehrke georgehrke commented Mar 10, 2016

@aspdye Compare the screenshots ;)

@aspdye
Copy link

@aspdye aspdye commented Mar 10, 2016

Have missed the second screenshot 😅

@ghost
Copy link
Author

@ghost ghost commented Mar 10, 2016

@georgehrke
Copy link
Contributor

@georgehrke georgehrke commented Mar 10, 2016

swapped the versions

@georgehrke georgehrke removed the core-bug label Mar 10, 2016
@aspdye
Copy link

@aspdye aspdye commented Mar 10, 2016

Why 1.0 instead of 1.0.0.0 like contacts does?

@georgehrke
Copy link
Contributor

@georgehrke georgehrke commented Mar 10, 2016

because calendar and contacts use different versioning schemes.
Ours is described in the wiki

@jancborchardt
Copy link
Member

@jancborchardt jancborchardt commented Mar 10, 2016

Could we all maybe just use semver.org? cc @DeepDiver1975 @Henni

@georgehrke
Copy link
Contributor

@georgehrke georgehrke commented Mar 10, 2016

not quite sure how to distinguish between minor and patch releases for the calendar. It's planned that all releases also contain new features.

@Henni
Copy link

@Henni Henni commented Mar 10, 2016

@jancborchardt I also discussed this with @irgendwie.
I'm wondering why owncloud needs four digits?

@georgehrke don't release patch releases. Just increase the patch number during development (for example if you need it to update the database or to mark significant changes during development).
But sometimes it might make sense to create patch releases. For example if you find a bug immediately after a major release.

@georgehrke
Copy link
Contributor

@georgehrke georgehrke commented Mar 10, 2016

I'm wondering why owncloud needs four digits?

major.minor.patch and the fourth digit is used to count alphas, betas and RCs.

if you need it to update the database

We don't use the database anymore ^^

For example if you find a bug immediately after a major release.

In this case I would simply release temporarily switch two mayor.minor.patch and release 1.0.1 (as an example), but I see reason to always keep the .0 in the releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.