Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #734

Merged
merged 3 commits into from Sep 7, 2016

Conversation

Projects
None yet
3 participants
@georgehrke
Copy link
Contributor

commented Sep 6, 2016

No description provided.

@coveralls

This comment has been minimized.

Copy link

commented Sep 6, 2016

Coverage Status

Coverage remained the same at 25.227% when pulling 95c2ea5 on update_deps into a875343 on master.

@georgehrke

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2016

I was not able to find any regressions :)

@georgehrke georgehrke referenced this pull request Sep 6, 2016

Closed

Week number support #262

2 of 3 tasks complete
@coveralls

This comment has been minimized.

Copy link

commented Sep 6, 2016

Coverage Status

Coverage remained the same at 25.227% when pulling 5323475 on update_deps into a875343 on master.

@tcitworld

This comment has been minimized.

Copy link
Member

commented Sep 7, 2016

Maybe this would be a good opportunity to handle all dependencies though mpm (since an user isn't supposed to install through git anyway).

@georgehrke

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2016

Maybe this would be a good opportunity to handle all dependencies though mpm

Why would you ditch bower?

Or do you just mean not to check in the code of dependencies?
I think it has some benefits, because if the developer unpublishes it, we still have the code in a safe place, but it's definitely something to discuss :)

@tcitworld

This comment has been minimized.

Copy link
Member

commented Sep 7, 2016

I don't mean to ditch bower, just move the libraries currently checked in to npm. npm certainly has issues, for instance packages disappearing, but I find it so sad to have such commits just to bring new versions for the dependencies.
Since the release packages will contain the dependencies anyway, I would say we're relatively safe.

update dependencies
adjust js head elements

adjust makefile

@georgehrke georgehrke force-pushed the update_deps branch from 5323475 to 0531c18 Sep 7, 2016

@georgehrke

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2016

I hardcoded the versions in the bower.json now :)

@tcitworld

This comment has been minimized.

Copy link
Member

commented Sep 7, 2016

Great. In fact, bower is quite enough for what we're doing here (the Makefile handles the rest).

@georgehrke

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2016

I was kind of expecting travis to fail 🙈

@georgehrke

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2016

I will look into the failing travis tests later today, will probably just fix #735 to get this resolved

@tcitworld tcitworld force-pushed the update_deps branch from aea2c5b to b460415 Sep 7, 2016

@tcitworld tcitworld force-pushed the update_deps branch from b460415 to 78a1728 Sep 7, 2016

@tcitworld

This comment has been minimized.

Copy link
Member

commented Sep 7, 2016

Fixed travis, but this can certainly be improved.

@georgehrke

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2016

thx :)

Will work on #735 soon

@coveralls

This comment has been minimized.

Copy link

commented Sep 7, 2016

Coverage Status

Coverage remained the same at 25.227% when pulling 78a1728 on update_deps into a875343 on master.

@georgehrke georgehrke merged commit 8dd4753 into master Sep 7, 2016

3 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 25.227%
Details

@georgehrke georgehrke deleted the update_deps branch Sep 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.