Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve progress reporting UI #3403

Closed
ckamm opened this issue Jul 3, 2015 · 16 comments

Comments

@ckamm
Copy link
Member

commented Jul 3, 2015

As discussed on IRC among @jancborchardt @guruz @ogoffart and me:

  • Show less informaion, in particularly don't show text to the right and below the progress bar.
  • Move information about all currently running jobs to the tooltip.
  • Possibly reduce the thickness and width of the progress bar.
  • Have a clear idea of how to display sync errors.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@jancborchardt

This comment has been minimized.

Copy link
Member

commented Jul 3, 2015

Good call on directly opening an issue! We should see how to best do that as soon as we have the new layout in, which @ogoffart and I worked on.

@guruz

This comment has been minimized.

Copy link
Collaborator

commented Jul 29, 2015

@ckamm You mentioned something about not being able to change displayed tooltips. Maybe this helps: https://stackoverflow.com/a/13720606/2941

@guruz guruz modified the milestones: 2.0 - Multi-account, 2.1-next Aug 6, 2015

@guruz guruz self-assigned this Aug 6, 2015

@guruz guruz modified the milestones: 2.1-next, 2.0 - Multi-account Aug 6, 2015

@guruz

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2015

I've pushed a display change for master/2.0 ... Now all transfers will be shown with complete bandwidth (before only part was shown #3095 (comment) thanks @ogoffart )

@ckamm

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2015

Here's a current snapshot:
progress

@jancborchardt

This comment has been minimized.

Copy link
Member

commented Aug 24, 2015

I’d change the layout additionally to the following, cut it down to 3 lines:

Syncing with local folder ownCloud
(thin progress bar, like the storage space bar)
9:30 minutes left, X MB of X MB, file 1 of X

  • cut the alias name
  • adjust »syncing with local folder« sentence and put in one line
  • shorten time display, fix singular/plural display as well
  • no decimal places on the file sizes, except GB
  • move detail info (the bottom line) like currently syncing file and exact sync speed to the tooltip (»sync is running« is not really a useful tooltip anyway ;)

Ok @ckamm? :)

@guruz

This comment has been minimized.

Copy link
Collaborator

commented Sep 13, 2015

I believe this is fixed with the recent changes done..

@guruz guruz closed this Sep 13, 2015

@jancborchardt

This comment has been minimized.

Copy link
Member

commented Sep 13, 2015

@ckamm is it, according to my comment above?

@guruz guruz modified the milestones: 2.2-next, 2.1-next Sep 30, 2015

@guruz guruz assigned ckamm and unassigned guruz Sep 30, 2015

@guruz guruz reopened this Sep 30, 2015

@ckamm

This comment has been minimized.

Copy link
Member Author

commented Sep 30, 2015

@jancborchardt No, a bunch of changes are left.

@jancborchardt

This comment has been minimized.

Copy link
Member

commented Oct 12, 2015

@ckamm let me know if you need more review, and if there’s any screenshots please show them. :)

@dragotin

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2015

@ckamm please do not strip the "syncing selected files" versus "syncing all files" as that is an important destinction. Also, I am very much against cutting the alias. If there are more than one sync connections the alias comes in very handy.

@jancborchardt hmm, I am not so happy about this review thing. We should really try to get stuff right in the first attempt, instead of reviewing afterwards and starting all over again. That had caused trouble in the past. Can we try that?

@phil-davis

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2015

Here is a sample (happens to be Version 2.0.2-nightly20151004 (build 5510)) of multiple folder sync connections that sync to/from different folder pairs on the server and client. Those do not use the sentence "Syncing selected files in your account with...".

  1. Maybe there is something to be made more common here? Anyway, this current difference needs to be taken into consideration when making more design decisions.

multi-sync

  1. If the "Syncing selected files" text is to be retained then I think it would be nice to say "Syncing all files" when that is actually the case (when there are not sub-folders unselected), and say "Syncing selected files" when the user has any sub-folder unselected.
@jancborchardt

This comment has been minimized.

Copy link
Member

commented Oct 12, 2015

If there are more than one sync connections the alias comes in very handy.

@dragotin as said before, the local folder name should just be used as the display name. From @phil-davis screenshot above it becomes clear that the name is just duplicated 3 times (alias, local path, remote path).

@phil-davis

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2015

On the 2nd folder sync connection in the screen shot I did choose a completely different folder name on the client. And in the others the local client side path is inside a different folder on D:\ - so the local client-side path seems reasonable to show - it is often different enough that I find it handy to be able to see where in the heck I put it :)
Agreed - the alias duplicates data already in Remote Path.

ogoffart added a commit that referenced this issue Oct 27, 2015

FolderDelegate: put the progressbar in place of the remote or local f…
…older #3403 #3569

So the size of the delegate does not change
@ckamm

This comment has been minimized.

Copy link
Member Author

commented Jan 19, 2016

The sync folder default info is:

<b><remote path> without starting / if that's not empty else appNameUI<b>
"Remote path: <remote path>" if it's not / else "Syncing selected files in your account with"
<local path> with the homedir stripped

I think the local and remote paths should be displayed for a sync folder, that's the essence of the sync connection. The duplication of the remote path should be removed. "Syncing selected files in your account with" is currently fluff (we never show "Syncing all files"). I expect that the remote path will often be shorter than the local path.

Suggestion: remove the middle line. Keep the rest.

The progress information expands below that, and we could follow @jancborchardt's suggestion for it:

thin progress bar
10 minutes left, 13 MB of 234 MB, file 12 of 102

Information on running jobs goes to the tooltip.

@dragotin @phil-davis @jancborchardt

@ckamm

This comment has been minimized.

Copy link
Member Author

commented Jan 21, 2016

I've made some tentative changes in this direction. @jancborchardt please review:
progress2-1
progress2-2

@jancborchardt

This comment has been minimized.

Copy link
Member

commented Jan 21, 2016

@ckamm looks much better already! :) Just a tiny wording change, I would say »folder« instead of »directory« since we mostly use »folder« everywhere as it’s simpler language.

@guruz guruz removed this from the 2.2.0-current milestone Feb 22, 2016

ckamm added a commit to ckamm/owncloud-client that referenced this issue Mar 29, 2016

Adjust size description strings owncloud#3403
@jancorchardt suggested to not have decimal places on file
sizes, except for GB.

ckamm added a commit to ckamm/owncloud-client that referenced this issue Mar 29, 2016

ckamm added a commit to ckamm/owncloud-client that referenced this issue Mar 29, 2016

ckamm added a commit to ckamm/owncloud-client that referenced this issue Mar 29, 2016

Folder info layout adjustments owncloud#3403
* Remove duplicate remote path
* Use thin progress bar
* Move bandwidth and file info to tooltip
* Shorten overall progress message

This also fixes owncloud#4562 by making the layout not dependent on the
width of the displayed text.

@ogoffart ogoffart closed this Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.