Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Window manager close button missing in settings dialog #3713

Closed
ghost opened this issue Aug 31, 2015 · 26 comments

Comments

@ghost
Copy link

commented Aug 31, 2015

The OS already provides a close button. There is no reason for an application to provide its own. All it does is clutter up the application.

@danimo

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2015

@dragotin dragotin added the Discussion label Aug 31, 2015

@dragotin dragotin added this to the backlog milestone Aug 31, 2015

@guruz guruz added the Design & UX label Aug 31, 2015

@guruz

This comment has been minimized.

Copy link
Collaborator

commented Aug 31, 2015

@ainola Which close button? Which OS? etc.

@phil-davis

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2015

I will guess the Close button in the bottom right corner of the ownCloud client GUI.
close

@danimo

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2015

My stance on this: It's a dialog, and as such should always have a button. I agree that we are wasting space on the right, but it could contain e.g. add/delete account or other stuff that is tab-specific.

@ghost

This comment has been minimized.

Copy link
Author

commented Aug 31, 2015

Indeed, I meant the bottom right button.

If we have a close button widget, why not include a minimize and maximize button as well? It is entirely redundant. Users should look to their window controls to manage windows, not the contents of the window.

On August 31, 2015 4:28:57 AM MDT, Daniel Molkentin notifications@github.com wrote:

My stance on this: It's a dialog, and as such should always have a
button. I agree that we are wasting space on the right, but it could
contain e.g. add/delete account or other stuff that is tab-specific.


Reply to this email directly or view it on GitHub:
#3713 (comment)

@danimo

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2015

@ainola It's a matter of expectation. All dialogs have a button to dismiss the content. If you want to change that, I wonder if starting at arbitrary applications is the way to go..

@ghost

This comment has been minimized.

Copy link
Author

commented Aug 31, 2015

If this is a KDE app, perhaps you are right: I don't know what KDE's HIG recommends. Gnome's HIG does not recommend this behavior, though.

"All dialogs have a button to dismiss the content."

Yes, it's that little 'X' button at the top right/left of your window. I wasn't aware that owncloud was considered a dialogue.... it's the main application window. To me, it's as if Firefox decided to allocate the bottom right space with a close widget.

@danimo

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2015

@ainola ownCloud doesn't really have a main window. It's supposed to behave like a service, and not bother you at all. If you choose to make changes to check the status, you open the dialog. It's more than a settings dialog, but it has dialog semantics nontheless.

@ghost

This comment has been minimized.

Copy link
Author

commented Aug 31, 2015

If it is supposed to behave like a service and not bother, why is there still no option to remove the status icon? :)

Also, by technicality it does has a main window. Whether that statement belies pure pedantry or not, I'll let you decide.

I have just noticed that the interface has been getting ever more cluttered and offered up a solution. I see that it was not well received. That's fine, though hopefully in the back of your mind you'll now notice close widgets as the pointless repetition they are :)

Thanks for all your work!

On August 31, 2015 6:48:50 AM MDT, Daniel Molkentin notifications@github.com wrote:

@ainola ownCloud doesn't really have a main window. It's supposed to
behave like a service, and not bother you at all. If you choose to make
changes to check the status, you open the dialog. It's more than a
settings dialog, but it has dialog semantics nontheless.


Reply to this email directly or view it on GitHub:
#3713 (comment)

@danimo

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2015

If it is supposed to behave like a service and not bother, why is there still no option to remove the status icon? :)

Because we're not there yet.

@danimo danimo closed this Aug 31, 2015

@jancborchardt

This comment has been minimized.

Copy link
Member

commented Sep 1, 2015

I totally agree that the Close button is totally redundant. Also talked to @ogoffart @guruz @jturcotte about that yesterday. I’d be in favor of removing it.

@guruz

This comment has been minimized.

Copy link
Collaborator

commented Sep 1, 2015

@ainola Ah, it is in the Linux/Windows implementation, that's why I never saw it. The OS X code is unfortunately different codebase for that dialog. thanks for reporting

@jancborchardt

This comment has been minimized.

Copy link
Member

commented Sep 1, 2015

By the way: At least on Ubuntu with Gnome, the dialog has no X button in the top right. Should have.

@jboisdequin

This comment has been minimized.

Copy link

commented Oct 22, 2015

I'm using Cinnamon on my Ubuntu 14.04 laptop. I am now unable to close the owncloud client window (see attachment). I don't have the 'X' button at the top right/left of the window

selection_010

@jancborchardt

This comment has been minimized.

Copy link
Member

commented Oct 22, 2015

@ogoffart @guruz same here with GNOME – the X in the top right is missing. Can we force that?

@guruz

This comment has been minimized.

Copy link
Collaborator

commented Oct 22, 2015

@jboisdequin @jancborchardt Could you guys check in the client settings dialog under "General" which Qt version it is using?

@jboisdequin

This comment has been minimized.

Copy link

commented Oct 22, 2015

I'm using Qt 4.8.6

2015-10-22 14:53 GMT+02:00 Markus Goetz notifications@github.com:

@jboisdequin https://github.com/jboisdequin @jancborchardt
https://github.com/jancborchardt Could you guys check in the client
settings dialog under "General" which Qt version it is using?


Reply to this email directly or view it on GitHub
#3713 (comment).

Julien BOISDEQUIN
IT Consultant
Mobile: +32475347237
GPG Key-ID: 775CF837

@guruz guruz changed the title Close button is poor design and should be removed [Linux] Window manager close button missing in settings dialog Oct 22, 2015

@guruz

This comment has been minimized.

Copy link
Collaborator

commented Oct 22, 2015

@jancborchardt And you?

@jboisdequin and which client version?

@guruz guruz reopened this Oct 22, 2015

@jboisdequin

This comment has been minimized.

Copy link

commented Oct 22, 2015

@guruz client version v2.0.2

danimo added a commit that referenced this issue Oct 22, 2015

Revert "Settings dialog: remove the close button #3713"
This reverts commit ebee6f0.

Unix window managers do not have a reliable way of hinting buttons,
so we need the close button.
@danimo

This comment has been minimized.

Copy link
Contributor

commented Oct 22, 2015

tl;dr There is no reliable way of hinting Window managers which buttons to show on Linux. All you can do is plea. We had requests to hide the maximize/minimize buttons but then you need to hint a dialog (which some windows decide not to show an X button for.

Let's simply do what every other sensible application in the world of the desktop does and reintroduce the close button.

@danimo danimo closed this Oct 22, 2015

@danimo

This comment has been minimized.

Copy link
Contributor

commented Oct 22, 2015

(Closing instead of ready-to-test because I just verified that the revert works).

@dragotin

This comment has been minimized.

Copy link
Contributor

commented Oct 22, 2015

Please. Never again we remove desktop standard gui elements.

@jancborchardt

This comment has been minimized.

Copy link
Member

commented Oct 22, 2015

Well, I guess every desktop has their own standard. So we need to introduce a non-standard element as a hack to fix it. If the X would be there, no need for the supposedly »standard« extra Close button. ;)

@danimo

This comment has been minimized.

Copy link
Contributor

commented Oct 22, 2015

If the X would be there

But it isn't, and we have to adjust to this reality. And we're certainly not doing per-desktop ifdefs.

@jturcotte

This comment has been minimized.

Copy link
Member

commented Oct 23, 2015

Maybe it only make sense to remove the close button if we use a non-dialog window type. This would then make the settings window show up in the DE's taskbar, so not really sure if it's something we want.

@dragotin

This comment has been minimized.

Copy link
Contributor

commented Oct 23, 2015

Very easy: No extra complexity and efforts for Close-button Yes/No. We simply keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.