Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully Handle Storage Limitations Errors #3736

Closed
MTRichards opened this issue Sep 2, 2015 · 5 comments

Comments

@MTRichards
Copy link

commented Sep 2, 2015

As an admin, I want filename characters (and other storage limitations) that are not allowed on certain ownCloud back end storage types to throw an error that the desktop client can understand, and then the desktop client notifies the user of the error
Example: certain special characters on SMB storage.

Acceptance Criteria:

  • File names allowed in ownCloud may not be allowed in the backend storage a customer chooses.
  • When a write operations is attempted to put the file to the backend storage, an error will be thrown and the file will not be synced with the backend.
  • If a file cannot be synced, the error thrown by the server will be captured by the desktop client and written to the desktop log

@MTRichards MTRichards added this to the 2.1-next milestone Sep 2, 2015

@ckamm ckamm added the p2-high label Sep 30, 2015

@guruz guruz assigned guruz and unassigned jturcotte Oct 20, 2015

@ogoffart ogoffart assigned MTRichards and unassigned guruz Oct 21, 2015

@ogoffart

This comment has been minimized.

Copy link
Collaborator

commented Oct 21, 2015

We have been reporting in the user intefrace the errors from the server for a long time.

Is there any specific example we need to test? What is wrong with the current behaviour?

@ogoffart ogoffart added the Needs info label Oct 21, 2015

@MTRichards

This comment has been minimized.

Copy link
Author

commented Oct 21, 2015

This was the outcome of our Berlin meetings, where the team said that we could stop checking for illegal characters on the client, and have the server do it instead. This would result in new errors, and that we were now in a place where the server could start to pass those along to the user so that we could tell them when, for example, illegal characters were not allowed to be synced because of a backend limitation. Until now, we have checked for those in the client and prevented sync, but the concept here is to try to sync with the server, and then the server lets the client know the errors based on what the backend allows to happen, not a pre-set list in the client. If I recall correctly.

@DeepDiver1975 was involved in the specifics, as was @dragotin @danimo and others.

@ogoffart ogoffart removed the Needs info label Oct 22, 2015

@ogoffart ogoffart assigned ogoffart and unassigned MTRichards Oct 22, 2015

ogoffart added a commit that referenced this issue Oct 22, 2015

csync_exclude: Don't ignore invalid char client side (#3736)
If the server does not support it, then the server will reply with an error
@Dianafg76

This comment has been minimized.

Copy link

commented Oct 27, 2015

I tested this issue:

With this characters (<, >, /, *, ?, '', |) on Winodws is working OK when you create a new Folder/File. If you go to Activity options you can see this message (The file name contains invalid characters that can not be ......)

BUT: With this character () I can't create a Folder o File on Server (you can see "Could not create folder, File name contains at least one invalid character")

Desktop v ownCloud-2.1.0.5584-nightly20151027-setup.exe
Server v {"installed":true,"maintenance":false,"version":"8.1.4.0","versionstring":"8.1.4 RC1","edition":""}

@Dianafg76 Dianafg76 removed the ReadyToTest label Oct 27, 2015

@ogoffart

This comment has been minimized.

Copy link
Collaborator

commented Oct 28, 2015

BUT: With this character () I can't create a Folder o File on Server (you can see "Could not create folder, File name contains at least one invalid character")

Yes, that's the expected error.

@ogoffart ogoffart closed this Oct 28, 2015

@Dianafg76

This comment has been minimized.

Copy link

commented Oct 28, 2015

Thanks

ogoffart added a commit that referenced this issue Oct 29, 2015

Propagator: Keep a meaningfull error with old server and invalid file…
… names

We changed the discovery code not to ignore files whose filename contains
charachter invalid on windows. (Because newer versions of the server
supports them)
Servers older than 8.1 will just say "Bad Request" as an error and it's a
regression against previous client version. So keep nice error even with
older server.

Relates to #3736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.