Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owncloudcmd fails smashbox due to "number of retries reached" in 2.1.0beta1 #4160

Closed
nickvergessen opened this issue Nov 18, 2015 · 8 comments

Comments

@nickvergessen
Copy link
Contributor

commented Nov 18, 2015

Since the update last night smashbox execution fails.

Example basicSync Smashbox test from cern:
https://github.com/owncloud/smashbox/blob/master/lib/test_basicSync.py

  1. Creator creates files and syncs
  2. Winner syncs
  3. Winner lists files (only welcome.txt is there)

Regression from 16c0789 for #4037 @ogoffart

The problem is that (although it's just the initial sync) the client takes 10+ retries until it successfully download and uploads the files.


Question: Is it intended that the client needs more than 3 syncs (default) for downloading 1 file and uploading 3? In the tests I did it was between 10 and 15 all the time

@nickvergessen nickvergessen changed the title owncloudcmd fails to download files since 2.1.0beta1 owncloudcmd fails smashbox due to "number of retries reached" in 2.1.0beta1 Nov 18, 2015

@nickvergessen

This comment has been minimized.

Copy link
Contributor Author

commented Nov 18, 2015

@ogoffart

This comment has been minimized.

Copy link
Collaborator

commented Nov 18, 2015

The error is: Local file changed during sync.

the reason is that we consider that if a file is newer than 2 seconds, we don't want to sync that file because it's too recent.

So this means we should add a 2sec pause before starting the smashbox jobs.

@nickvergessen

This comment has been minimized.

Copy link
Contributor Author

commented Nov 18, 2015

oh, that's ... bad I guess? It slows us down quite heavily with tests.
Is this only after creating files, or even after sync + modify?

@ogoffart

This comment has been minimized.

Copy link
Collaborator

commented Nov 18, 2015

Even after sync + modify

We could change this time value with an environement variable for example.

@nickvergessen

This comment has been minimized.

Copy link
Contributor Author

commented Nov 19, 2015

Or with a parameter to the cmd call (like with number of retries)? That would be easiest for us.

ogoffart added a commit that referenced this issue Nov 20, 2015

owncloudcmd: Don't do a check that file are older than 2s (#4160)
This is required for the smashbox test to pass
@ogoffart

This comment has been minimized.

Copy link
Collaborator

commented Nov 20, 2015

Next build will not check for too recent files.

Note: there might be smashbox tests that were relying on several syncs to be run which hapenned because of these recent files.
Maybe these will start failing. In that case this either mean that the client should be fixed to request a new sync in that case, or that the test must manually run the sync several times.

@nickvergessen

This comment has been minimized.

Copy link
Contributor Author

commented Nov 20, 2015

Smashing atm and looks promising

@nickvergessen

This comment has been minimized.

Copy link
Contributor Author

commented Nov 20, 2015

works and smashbox is passing again

@nickvergessen nickvergessen added this to the 2.1-current milestone Nov 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.