Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop QtWebKit from build dependencies #6451

Closed
SamuAlfageme opened this issue Apr 11, 2018 · 10 comments

Comments

@SamuAlfageme
Copy link
Contributor

commented Apr 11, 2018

After having #5668 implemented and https://marketplace.owncloud.com/apps/oauth2 gaining more and more adoption, we're in the right track (platform-wise) to drop the requirement of shipping a full-blown browser together with the client.

Today I was looking at the differences and benefits we'll get in the e.g. .app bundles on install time and QtWebKit bloats the size in disk more than 50% (45.7 MB build with -DNO_SHIBBOLETH=1 vs. 92.2 MB wo/ the build flag).

@jnweiger

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2018

Will master build without QtWebKit now?

@guruz

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2018

@jnweiger only if you pass -DNO_SHIBBOLETH=1

@ogoffart ogoffart changed the title [Placeholder] Drop QtWebKit from build dependencies Drop QtWebKit from build dependencies May 28, 2018

ogoffart added a commit that referenced this issue Nov 27, 2018
@ogoffart

This comment has been minimized.

Copy link
Collaborator

commented Dec 3, 2018

The packages just need to update the package to remove this dependences.

@veprbl veprbl referenced this issue Dec 30, 2018
5 of 60 tasks complete

@guruz guruz self-assigned this Apr 23, 2019

@guruz

This comment has been minimized.

Copy link
Collaborator

commented Apr 23, 2019

I'll check macOS and NSIS now

guruz added a commit that referenced this issue Apr 23, 2019
guruz added a commit that referenced this issue Apr 27, 2019
@guruz

This comment has been minimized.

Copy link
Collaborator

commented Apr 27, 2019

NSIS and macOS merged #7158
MSI and Linux/Drone pending.
Linux OBS won't do.

@guruz

This comment has been minimized.

Copy link
Collaborator

commented May 24, 2019

MSI is done

@guruz

This comment has been minimized.

Copy link
Collaborator

commented Jun 4, 2019

@dschmidt @jnweiger How is this with the Linux/Drone builds? Done already so we can close here?

@jnweiger

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

2.6.0 will still be done with the openSUSE Build service. I'll remove the dependency and see what happens.

@jnweiger

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

@jnweiger

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

https://gitea.owncloud.services/client/build-linux/commit/32e709e29dd9d136067575c524bbb86ed9791516

https://gitea.owncloud.services/ownbrander/scripting/commit/a55cf01cce3f9c1de098cfded23177d081790050

done.

Tested ownCloud version 2.6.0daily20190604 (build 914) on Linux Mint 19

login with web token and password works. syncs fine. No more ocqt*qebkit packages on my system!

@jnweiger jnweiger closed this Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.