Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client 2.6 cannot upload files larger 2.1 GB #7506

Closed
jnweiger opened this issue Oct 8, 2019 · 9 comments

Comments

@jnweiger
Copy link
Contributor

commented Oct 8, 2019

  • Start client 2.6.0daily20190923 or client-2.6.0daily20191008 using Qt-5.12.4 on Windows 10
  • connect to a 10.3 alpha server,
  • wait until the initial sync finishes.
  • move a 2.5 GB file into the local sync folder of the client.
  • After the next sync run, this file is flagged with a red (X) and the 'not synced' tab says 'An attempt was made to move the file pointer before the beginning of the file.'
    image

Expected behaviour: It uploads.

@jnweiger

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

Client 2.5.4 can upload the same file with the same server:
image

It is a regression.

@michaelstingl michaelstingl added this to the 2.6.0 milestone Oct 8, 2019
@HanaGemela

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

The same happens on macOS 10.14.6, client 2.6.0 RC1, server 10.3.0 RC1
Works with client 2.5.4

Steps to recreate:

  1. Upload a 6GB file from the client to the server

Actual result: Unknown error

10-08 18:00:48:342 [ info sync.propagator.upload ]: Resuming "dvd1.iso" ; sent = 2210000000 ; total= 7135559680 10-08 18:00:48:342 [ warning sync.propagator.upload ]: Could not prepare upload device: "Unknown error" 10-08 18:00:48:342 [ debug sync.database.sql ] [ OCC::SqlQuery::bindValue ]: SQL bind 1 QVariant(QString, "dvd1.iso") 10-08 18:00:48:342 [ debug sync.database.sql ] [ OCC::SqlQuery::exec ]: SQL exec "SELECT lastTryEtag, lastTryModtime, retrycount, errorstring, lastTryTime, ignoreDuration, renameTarget, errorCategory, requestId FROM blacklist WHERE path=?1 COLLATE NOCASE" 10-08 18:00:48:342 [ warning sync.propagator ]: Could not complete propagation of "dvd1.iso" by OCC::PropagateUploadFileNG(0x600002173de0) with status OCC::SyncFileItem::SoftError and error: "Unknown error" 10-08 18:00:48:342 [ debug sync.statustracker ] [ OCC::SyncFileStatusTracker::slotItemCompleted ]: Item completed "dvd1.iso" OCC::SyncFileItem::SoftError 8

@jnweiger

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

Reprodced also in Linux with client 2.6.0daily20190922

image

We have different error messages on Linux and Mac now, but probably the same bug than on Windows.

It's a platform-independent regression now. Sigh.

@jnweiger jnweiger changed the title Win10: client cannot upload files larger 2.1 GB Client 2.6 cannot upload files larger 2.1 GB Oct 8, 2019
@jnweiger

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

Download a 2.5 GB file into the Linux client works fine.
Download a 2.5 GB file into the Windows client works fine.
Upload a 2.0 GB file from a Windows client works fine.

ogoffart added a commit that referenced this issue Oct 9, 2019
Issue #7506

This is a regression introduced by the delta sync feature (as the chunk offset
changed from being the chunk number to be the byte offset, it needs to be a
qint64 now)
@ogoffart

This comment has been minimized.

Copy link
Collaborator

commented Oct 9, 2019

The regression was caused by the delta sync patch.
Fix in #7508

ogoffart added a commit that referenced this issue Oct 9, 2019
Issue #7506

This is a regression introduced by the delta sync feature (as the chunk offset
changed from being the chunk number to be the byte offset, it needs to be a
qint64 now)
@jnweiger

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

Retested on Linux with testpilotcloud version 2.6.0pr7508 (build 1563)
Git revision 8353d09

2.5 GB upload works like a charm. Thank you!

@mrow4a

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

@ogoffart @jnweiger @guruz probably would be good to add 1 more scenario in https://github.com/owncloud/smashbox/blob/master/lib/owncloud/test_chunking.py to test chunking also for very large file over integer range. Makes sense?

@mrow4a

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

ogoffart added a commit that referenced this issue Oct 9, 2019
Issue #7506

This is a regression introduced by the delta sync feature (as the chunk offset
changed from being the chunk number to be the byte offset, it needs to be a
qint64 now)
@ogoffart ogoffart removed the PR available label Oct 9, 2019
@ogoffart

This comment has been minimized.

Copy link
Collaborator

commented Oct 9, 2019

PR merged.
Yes, i guess a smashbox test for much larger files would make a lot of sense.

@ogoffart ogoffart closed this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.