Fix crash in selective sync configuration #10065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit restores the use of FolderStatusDelegate::data(...) to check whether a folder is ready. The two additions fix two different ways in which the client could crash. Using data(...) makes sure we use the right data structure to look up the ready state for the subfolders. Using folder(...) rightfully causes an index out of range error. This commit partially reverts #10058 and restores a previous version of said PR.
|
Kudos, SonarCloud Quality Gate passed! |
|
Tested on Ubuntu 20.04 and 22.04 as well as Windows 10 and 11, this PR fixes the crash apparently. |
erikjv
approved these changes
Aug 29, 2022
_is_blacklisted.png){kind=link}
_are_copied_over_to_the_server.png){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit restores the use of FolderStatusDelegate::data(...) to check whether a folder is ready. The two additions fix two different ways in which the client could crash.
Using data(...) makes sure we use the right data structure to look up the ready state for the subfolders. Using folder(...) rightfully causes an index out of range error.
This commit partially reverts #10058 and restores a previous version of said PR.