Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccountSettings: Add a toolbox button for the account specific actions. #4139

Merged
merged 2 commits into from Nov 16, 2015

Conversation

@dragotin
Copy link
Contributor

commented Nov 13, 2015

Also move the 'Add Account' button from the General Tab, where it
is not properly found, to the new account toolbox.

This results in a look like that:
toolboxbutton
Also note the Add-Account functionality, that moved from the General tab to here.

@jancborchardt how is that? @phil-davis as we talked about in the other issue #4134

AccountSettings: Add a toolbox button for the account specific actions.
Also move the 'Add Account' button from the General Tab, where it
is not properly found, to the new account toolbox.
@ogoffart

This comment has been minimized.

Copy link
Collaborator

commented Nov 13, 2015

👍 Looks great

@danimo

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2015

👍 Liking it

@phil-davis

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2015

👍 Looks good.
This is one place to put the "Add account" option. I know there has been discussion about this before, and new users had trouble finding in its old place, in the General tab. This seems better, and when there is no account defined at all the wizard will start.
The other option is to have a "+" Add Account button up in the top row, along with the existing account icons and the Activity, General and Network tabs.
Hmmm - maybe what is here is the way to go.

@pierrejochem

This comment has been minimized.

Copy link

commented Nov 13, 2015

👍

@jancborchardt

This comment has been minimized.

Copy link
Member

commented Nov 16, 2015

Great stuff @dragotin! :)

Only details:

  • »Add new account« should be sorted in first (as destructive actions always should go to the very bottom of a list)
  • »account« lowercase and no ellipsis at the end
  • to make that dropdown more discoverable, can we add a triangle to the right? If there’s no default image, we can use the triangle from core (SVG with same name also in there)
AccountSettings: Address jans suggestions in #4139
- Changed sequence of menu items
- lowercased entries
- removed the "Account" from entries, its in the toolbox button already
- added a little space between toolbox button label and the rectangle.
dragotin added a commit that referenced this pull request Nov 16, 2015
Merge pull request #4139 from owncloud/account_toolbox
AccountSettings: Add a toolbox button for the account specific actions.

@dragotin dragotin merged commit 74ed0b4 into master Nov 16, 2015

@jancborchardt jancborchardt deleted the account_toolbox branch Nov 16, 2015

@guruz

This comment has been minimized.

Copy link
Collaborator

commented Nov 16, 2015

This would have been better in the tray menu..

@guruz

This comment has been minimized.

Copy link
Collaborator

commented Nov 16, 2015

If I see it at this place, I'll think this is about adding (creating?) an account on that server. In the tray menu you can put it in a more generic place.

@jancborchardt

This comment has been minimized.

Copy link
Member

commented Nov 16, 2015

@guruz the tray menu is for actions which are performed regularly. Adding an account is not, so it does not belong in there.

@ogoffart

This comment has been minimized.

Copy link
Collaborator

commented Nov 16, 2015

I think the first entry should probably be "Log In" especially when we are in disconnected mode (because the password was changed for example, or that the shiboeth session expired)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.