Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ownCloud icon to Dolphin context menu #6919

Closed
wants to merge 1 commit into from

Conversation

nicolasfella
Copy link

Most actions in Dolphin's context menu have an icon.

image

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2018

CLA assistant check
All committers have signed the CLA.

@ogoffart
Copy link
Contributor

ogoffart commented Dec 7, 2018

Thanks for your merge request. I think we should indeed show the icon there.
However, I don't think we can simply use "owncloud" because of the branding. We should query the socketapi to get the icon the same way we ask for the title or for the menus.

@dschmidt
Copy link
Member

dschmidt commented Dec 7, 2018

@ogoffart What happens if several branded/branded and unbranded clients are installed? Do they all load independently or is only one loaded and handles whichever client?

If all are loaded and only handle their respective client, we could probably also just use APPLICATION_ICON_NAME to hardcode it in the extension:
https://github.com/owncloud/client/blob/master/CMakeLists.txt#L154 https://github.com/owncloud/client/blob/master/mirall.desktop.in#L8

In fact it looks like mirall.desktop.in uses APPLICATION_EXECUTABLE although it should use APPLICATION_ICON_NAME (which is based on APPLICATION_SHORTNAME (!)) ->
https://github.com/owncloud/client/blob/master/src/gui/CMakeLists.txt#L235

(How) does this relate to #6921?

@guruz
Copy link
Contributor

guruz commented Dec 11, 2018

We should query the socketapi to get the icon the same way we ask for the title or for the menus.

@nicolasfella You can find inspiration on how to do this in 2fddf05

@guruz
Copy link
Contributor

guruz commented Mar 10, 2019

@nicolasfella Any news? :)

@TheOneRing
Copy link
Member

Closing abandoned pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants