Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the handling of errors in convertToPlacholder and updateMetaData #8787

Merged
merged 1 commit into from Jun 28, 2021
Merged

Improve the handling of errors in convertToPlacholder and updateMetaData #8787

merged 1 commit into from Jun 28, 2021

Conversation

TheOneRing
Copy link
Member

@TheOneRing TheOneRing commented Jun 28, 2021 •
edited

Depends on #8786

@TheOneRing TheOneRing changed the title Work/improve update meta data error Improve the handling of errors in convertToPlacholder and updateMetaData Jun 28, 2021
@TheOneRing TheOneRing force-pushed the work/improve_updateMetaData_error branch 3 times, most recently from be78631 to 73bdb3c Compare June 28, 2021 15:46
dragotin
dragotin approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@dragotin dragotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String "File locked" should be "File is currently in use"

@TheOneRing TheOneRing force-pushed the work/improve_updateMetaData_error branch from 73bdb3c to 23bee3f Compare June 28, 2021 16:14
@TheOneRing
Improve the error message returned by updateMetadata
b10acce 
Also properly handle the case the the file can't be converted to a placeholder
as it is locked
@TheOneRing TheOneRing force-pushed the work/improve_updateMetaData_error branch from 23bee3f to b10acce Compare June 28, 2021 16:16
@TheOneRing TheOneRing merged commit 1aa25a6 into master Jun 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the work/improve_updateMetaData_error branch June 28, 2021 16:17
@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

This was referenced Aug 23, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragotin dragotin dragotin approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

@fmoc fmoc Awaiting requested review from fmoc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheOneRing @dragotin