add stats guest_count, renamed count to total_count

[AlexAndBear]

Show guest count in stats.

Fixes:

• https://github.com/owncloud/enterprise/issues/3467

[CLAassistant]

All committers have signed the CLA.

[AlexAndBear]

@phil-davis userTypeHelper available since 10.7 how do we handle this?

[phil-davis]

@phil-davis userTypeHelper available since 10.7 how do we handle this?

@janackermann it was only complaining about the var not being declared in the class: ae068c1

And the acceptance tests against latest core should work fine, because the latest core release tarball is already 10.7.

I looked at the acceptance tests for 5 seconds - there is only 1 scenario, no interesting test cases there! I guess the unit tests cover checking that the output has the expected stuff.

[AlexAndBear]

Thank you!

[phil-davis]

Locally tested with:

$ php occ configreport:generate | grep -B 4 -A 8 guest_count
    "stats": {
        "users": {
            "Database": {
                "total_count": 5,
                "guest_count": 0,
                "seen": 5,
                "logged in (30 days)": 1
            }
        },
        "groups": {
            "OC\\Group\\Database": 2
        }
    },

There is a users section with total_count and guest_count.

[phil-davis]

LGTM - @jvillafanez review please.

[AlexAndBear]

@phil-davis I will bump min version 10.8 since we need a slight change in the core

[jvillafanez]

No workaround for the private class... this will have to do for now.

[phil-davis]

Note: https://drone.owncloud.com/owncloud/configreport/1368/4/3

core master needs to say it is at 10.8 - see PR owncloud/core#38745

[AlexAndBear]

@phil-davis needed to remove latest temporary from drone.star, agree?

[phil-davis]

@phil-davis needed to remove latest temporary from drone.star, agree?

agree - we know that this new configreport code does not work against latest = 10.7.0

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information