Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account


merged 3 commits into from Jun 27, 2017


Copy link

@t-bucchi t-bucchi commented May 26, 2017

I implement two features for Japanese.

  • User can change the name order like 'LastName FirstName'

In Japan, a phonetic (pronounce) name is one of the essential feature for address book.
Because, the Kanji character has many pronunciation.
So, usually contact list is sorted by phonetic order.

Second, the name order is 'LastName FirstName' in Japan.

Would you review and merge my code?

Copy link

@codecov-io codecov-io commented May 26, 2017

Codecov Report

Merging #595 into master will decrease coverage by 0.33%.
The diff coverage is 6.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #595      +/-   ##
- Coverage   15.28%   14.95%   -0.34%     
  Files          49       51       +2     
  Lines         955     1003      +48     
+ Hits          146      150       +4     
- Misses        809      853      +44
Impacted Files Coverage Δ
js/services/sortBy_service.js 70.58% <ø> (ø) ⬆️
js/models/contact_model.js 35.63% <0%> (-3.61%) ⬇️
js/services/settings_service.js 11.11% <10%> (-1.39%) ⬇️
js/components/Options/Options_controller.js 12.5% <12.5%> (ø)
...s/components/detailsItem/detailsItem_controller.js 2.63% <4.54%> (+1.06%) ⬆️
js/components/Options/Options_directive.js 50% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d16f89a...58a2f09. Read the comment docs.

Copy link

@DeepDiver1975 DeepDiver1975 commented May 27, 2017

Nice. Thanks a lot!
Can I ask you for an example vcard for testing? Thx

Copy link
Contributor Author

@t-bucchi t-bucchi commented May 27, 2017

Thanks for your response.
I attached a example vCard data that is created by Google Contacts.

@DeepDiver1975 DeepDiver1975 self-requested a review Jun 27, 2017
@DeepDiver1975 DeepDiver1975 added this to the 1.6 milestone Jun 27, 2017
@DeepDiver1975 DeepDiver1975 merged commit 372755e into owncloud:master Jun 27, 2017
1 of 3 checks passed
1 of 3 checks passed
codecov/patch 6.89% of diff hit (target 15.28%)
codecov/project 14.95% (-0.34%) compared to d16f89a
continuous-integration/travis-ci/pr The Travis CI build passed
@t-bucchi t-bucchi deleted the t-bucchi:merge branch Jul 9, 2017
@t-bucchi t-bucchi restored the t-bucchi:merge branch Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.