Encode the URI properly

LukasReschke · LukasReschke · commit b24c929cc006 · 2012-12-16T11:24:01.000+01:00
Backport of eafa9b2
diff --git a/apps/bookmarks/js/bookmarks.js b/apps/bookmarks/js/bookmarks.js
@@ -141,7 +141,7 @@ function updateBookmarksList(bookmark) {
 	var taglist = '';
 	for ( var i=0, len=tags.length; i<len; ++i ){
 		if(tags[i] != '')
-			taglist = taglist + '<a class="bookmark_tag" href="'+replaceQueryString( String(window.location), 'tag', encodeURIComponent(tags[i])) + '">' + tags[i] + '</a> ';
+			taglist = taglist + '<a class="bookmark_tag" href="'+replaceQueryString(escapeHTML(String(window.location)), 'tag', encodeURIComponent(tags[i])) + '">' + tags[i] + '</a> ';
 	}
 	if(!hasProtocol(bookmark.url)) {
 		bookmark.url = 'http://' + bookmark.url;

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ function updateBookmarksList(bookmark) {`
`141`	`141`	`var taglist = '';`
`142`	`142`	`for ( var i=0, len=tags.length; i<len; ++i ){`
`143`	`143`	`if(tags[i] != '')`
`144`		`- taglist = taglist + '<a class="bookmark_tag" href="'+replaceQueryString( String(window.location), 'tag', encodeURIComponent(tags[i])) + '">' + tags[i] + '</a> ';`
	`144`	`+ taglist = taglist + '<a class="bookmark_tag" href="'+replaceQueryString(escapeHTML(String(window.location)), 'tag', encodeURIComponent(tags[i])) + '">' + tags[i] + '</a> ';`
`145`	`145`	`}`
`146`	`146`	`if(!hasProtocol(bookmark.url)) {`
`147`	`147`	`bookmark.url = 'http://' + bookmark.url;`