PHP 5.3 issue on master

[DeepDiver1975]

@LukasReschke can you please have a look? THX

00:16:57.852 TestSuite 'CertificateManagerTest': Did not clean up proxies
00:16:57.917 PHP Fatal error:  Call to undefined function OC\Security\hex2bin() in /var/lib/jenkins/jobs/server-master-linux-php533/workspace/database/oci/label/master/lib/private/security/crypto.php on line 102
00:16:57.917 PHP Stack trace:
00:16:57.917 PHP   1. {main}() /usr/bin/php53/phpunit:0
00:16:57.917 PHP   2. PHPUnit_TextUI_Command::main() /usr/bin/php53/phpunit:46
00:16:57.917 PHP   3. PHPUnit_TextUI_Command->run() /usr/share/php53/lib/php/PHPUnit/TextUI/Command.php:129
00:16:57.917 PHP   4. PHPUnit_TextUI_TestRunner->doRun() /usr/share/php53/lib/php/PHPUnit/TextUI/Command.php:176
00:16:57.917 PHP   5. PHPUnit_Framework_TestSuite->run() /usr/share/php53/lib/php/PHPUnit/TextUI/TestRunner.php:349
00:16:57.917 PHP   6. PHPUnit_Framework_TestSuite->run() /usr/share/php53/lib/php/PHPUnit/Framework/TestSuite.php:705
00:16:57.917 PHP   7. PHPUnit_Framework_TestSuite->run() /usr/share/php53/lib/php/PHPUnit/Framework/TestSuite.php:705
00:16:57.917 PHP   8. PHPUnit_Framework_TestSuite->runTest() /usr/share/php53/lib/php/PHPUnit/Framework/TestSuite.php:745
00:16:57.917 PHP   9. PHPUnit_Framework_TestCase->run() /usr/share/php53/lib/php/PHPUnit/Framework/TestSuite.php:775
00:16:57.917 PHP  10. PHPUnit_Framework_TestResult->run() /usr/share/php53/lib/php/PHPUnit/Framework/TestCase.php:783
00:16:57.917 PHP  11. PHPUnit_Framework_TestCase->runBare() /usr/share/php53/lib/php/PHPUnit/Framework/TestResult.php:648
00:16:57.917 PHP  12. PHPUnit_Framework_TestCase->runTest() /usr/share/php53/lib/php/PHPUnit/Framework/TestCase.php:838
00:16:57.917 PHP  13. ReflectionMethod->invokeArgs() /usr/share/php53/lib/php/PHPUnit/Framework/TestCase.php:983
00:16:57.917 PHP  14. CryptoTest->testDefaultEncrypt() /usr/share/php53/lib/php/PHPUnit/Framework/TestCase.php:983
00:16:57.917 PHP  15. OC\Security\Crypto->decrypt() /var/lib/jenkins/jobs/server-master-linux-php533/workspace/database/oci/label/master/tests/lib/security/crypto.php:34
00:16:58.052 Build step 'Execute shell' marked build as failure
00:16:58.058 Recording test results
00:16:58.068 Started calculate disk usage of build
00:16:58.069 Finished Calculation of disk usage of build in 0 seconds
00:16:58.070 Started calculate disk usage of workspace
00:16:58.411 Finished Calculation of disk usage of workspace in 0 seconds
00:16:58.413 Finished: FAILURE

[DeepDiver1975]

https://ci.owncloud.org/job/server-master-linux-php533/database=oci,label=master/lastCompletedBuild/console

[LukasReschke]

How much I love that shitty unsupported thing called 5.3

@karlitschek @MTRichards Statement required if we will still support 5.3 for ownCloud 8.

[LukasReschke]

Explanation: hex2bin has been introduced with PHP 5.4.0 and obviously not backported since PHP 5.3 was for a long time in "security fix only" phase and has now also reached end-of-life.

If we want to fix this we need to add a custom implementation of hex2bin to core. - But I'd seriously prefer to just drop PHP 5.3 for ownCloud 8.

[LukasReschke]

See #11006

[LukasReschke]

That said: We only noticed this bug because we have 100% test coverage on the security utils. I don't want to know how many other things are broken and untested because we do not have tests and nobody of the devs really use 5.3 ;-)

[karlitschek]

@LukasReschke most likely yes. Unless RHEL 6 suddenly disappears from this planet.

[LukasReschke]

I'd kill for that ;-)

[MTRichards]

Agreed with @karlitschek
In theory RHEL is supposed to support 5.4, but I don't see them push that out and displacing 5.3 on existing systems.

[MTRichards]

http://www.redhat.com/en/about/blog/red-hat-software-collections-1.0-beta-now-available

@carlaschroder Something we also need to document in the installation side of things is that this is coming, and that we recommend all RHEL 6 users follow this path when it comes out of beta.

CentOS 6 users already have a path to this, and we need to document what it is - including the part on how to remove php 5.3 in all its forms, and instead add 5.4.

[carlaschroder]

Acked and tracked.

[carlaschroder]

release noted.