Files app can't show thumbnails of BMP pictures #16461

Closed
SergioBertolinSG opened this Issue May 20, 2015 · 10 comments

Projects

None yet

8 participants

@SergioBertolinSG
Member

Steps to reproduce

  1. Upload BMP files.

Expected behaviour

there is a thumbnail.

Actual behaviour

In chrome there is no thumbnail.

screen shot 2015-05-20 at 10 58 27

Server configuration

Operating system:
Ubuntu 14.04

Web server:
Apache

Database:
MySQL

PHP version:
5.5.9

ownCloud version: (see ownCloud admin page)
{"installed":true,"maintenance":false,"version":"8.1.0.6","versionstring":"8.1 beta 2","edition":"Enterprise"}

Client configuration

browser
Chrome 41

@SergioBertolinSG SergioBertolinSG added this to the 8.2-next milestone May 20, 2015
@nickvergessen
Contributor

Is this specific to chrome?

@SergioBertolinSG
Member

Yes, not happening in firefox, safari or ie.

@oparoz
Contributor
oparoz commented May 20, 2015

I don't get a preview at all with master on PHP 5.5

"message":"Generating preview for \"\/sample.bmp\" with \"OC\\Preview\\BMP\""
"message":"OC_Image->fixOrientation() Image is not a JPEG."
"message":"OC_Image->fixOrientation() Orientation: -1"
"message":"OC_Image->data. Could not guess mime-type, defaulting to png"
"message":"OC_Image->data. Could not guess mime-type, defaulting to png"
"message":"Exception: {\"Exception\":\"Exception\",\"Message\":\"\\\\OC_Image::_output(): \\\"image\\\/x-ms-bmp\\\" is not supported when forcing a specific output format\",\"Code\":0,\"Trace\":\"#0 lib\\\/private\\\/image.php(193): OC_Image->_output(NULL, 'image\\\/x-ms-bmp')\\n#1 lib\\\/private\\\/preview.php(547): OC_Image->show(NULL)\\n#2 core\\\/ajax\\\/preview.php(61): OC\\\\Preview->showPreview()\\n#3 lib\\\/private\\\/route\\\/route.php(153) : runtime-created function(1): require_once('\\\/home\\\/icloud\\\/do...')\\n#4 [internal function]: __lambda_func(Array)\\n#5 lib\\\/private\\\/route\\\/router.php(272): call_user_func('\\\\x00lambda_97', Array)\\n#6 lib\\\/base.php(862): OC\\\\Route\\\\Router->match('\\\/core\\\/preview.p...')\\n#7 index.php(40): OC::handleRequest()\\n#8 {main}\",\"File\":\"lib\\\/private\\\/image.php\",\"Line\":260}

Tested with http://file.fyicenter.com/51_Image_Picture_.BMP_File_Extension_for_Bitmap_Image_Files.html

@oparoz
Contributor
oparoz commented May 20, 2015

The funny thing is that if I upload it again to overwrite it, I get previews in the dialogue asking me what I want to do.

Gallery+ also loads it fine both in the app and in the slideshow

@oparoz
Contributor
oparoz commented May 20, 2015

@georgehrke Any idea what's killing the filelist thumbnail generator?

@oparoz oparoz changed the title from BMP files thumbnail not shown in chrome to Files app can't show thumbnails of BMP pictures May 21, 2015
@oparoz oparoz added the app:files label May 21, 2015
@jzee jzee added a commit to jzee/core that referenced this issue Jul 20, 2015
@jzee jzee don't throw on the first attempt of outputting a bmp
this fixes owncloud#16461
tested with http://file.fyicenter.com/a/sample.bmp as an image
0c36e1a
@jzee jzee added a commit to jzee/core that referenced this issue Jul 20, 2015
@jzee jzee files app can't show thumbnails of BMP pictures #16461
this fixes owncloud#16461
right after upload, there is a different, non-normalized mimetype with the image
that throws because it is not handled.
d381a64
@jzee jzee added a commit to jzee/core that referenced this issue Jul 20, 2015
@jzee jzee fix bmp preview
this fixes #16461
there is a different mimetype with the image right after the upload,
due to the way how mimetypes are normalized (that being the root cause)
c02843e
@jzee jzee referenced this issue Jul 20, 2015
Closed

fix bmp preview #17754

@PVince81
Collaborator

Is this still an issue with 8.2 beta ?

@SergioBertolinSG
Member

Yes, still happening.
some logs:

{"reqId":"OkAzAZgW1mWlVqaQWicy","remoteAddr":"hided_ip","app":"index","message":"Exception: {\"Exception\":\"Exception\",\"Message\":\"\\\\OC_Image::_output(): \\\"image\\\/x-ms-bmp\\\" is not supported when forcing a specific output format\",\"Code\":0,\"Trace\":\"#0 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/image.php(193): OC_Image->_output(NULL, 'image\\\/x-ms-bmp')\\n#1 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/preview.php(790): OC_Image->show(NULL)\\n#2 \\\/opt\\\/owncloud\\\/core\\\/ajax\\\/preview.php(62): OC\\\\Preview->showPreview()\\n#3 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/route\\\/route.php(154) : runtime-created function(1): require_once('\\\/opt\\\/owncloud\\\/c...')\\n#4 [internal function]: __lambda_func(Array)\\n#5 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/route\\\/router.php(281): call_user_func('?lambda_59', Array)\\n#6 \\\/opt\\\/owncloud\\\/lib\\\/base.php(893): OC\\\\Route\\\\Router->match('\\\/core\\\/preview.p...')\\n#7 \\\/opt\\\/owncloud\\\/index.php(40): OC::handleRequest()\\n#8 {main}\",\"File\":\"\\\/opt\\\/owncloud\\\/lib\\\/private\\\/image.php\",\"Line\":260}","level":4,"time":"2015-09-22T08:44:40+00:00"}
@oparoz
Contributor
oparoz commented Sep 22, 2015

One possible fix was never merged:
#17754

@cmonteroluque
Contributor

This issue will fall off 8.2 if not resolved by 6 Oct

@cmonteroluque cmonteroluque modified the milestone: backlog, 8.2-current Oct 5, 2015
@butonic
Member
butonic commented Nov 6, 2015

Anyone interested in fixing this might want to have a look at https://blog.mozilla.org/nnethercote/2015/11/06/i-rewrote-firefoxs-bmp-decoder/ which contains a reference to testimages for the various bmp formats.

@MorrisJobke MorrisJobke added a commit that referenced this issue Feb 13, 2016
@MorrisJobke MorrisJobke Fix BMP support
* fixes #16461
444d4ac
@MorrisJobke MorrisJobke added a commit that referenced this issue Feb 14, 2016
@MorrisJobke MorrisJobke Fix BMP support
* fixes #16461
e60e0fe
@MorrisJobke MorrisJobke added a commit that referenced this issue Feb 14, 2016
@MorrisJobke MorrisJobke Fix BMP support
* fixes #16461
ce4d518
@MorrisJobke MorrisJobke added a commit that referenced this issue Feb 14, 2016
@MorrisJobke MorrisJobke Fix BMP support
* fixes #16461
5b1c099
@MorrisJobke MorrisJobke modified the milestone: 9.0-current, backlog Feb 14, 2016
@MorrisJobke MorrisJobke removed their assignment Feb 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment