Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move icon from OCS Share API to javascript #16531

Closed
rullzer opened this issue May 22, 2015 · 3 comments
Closed

Move icon from OCS Share API to javascript #16531

rullzer opened this issue May 22, 2015 · 3 comments

Comments

@rullzer
Copy link
Contributor

rullzer commented May 22, 2015

#16127 introduced the icon field to OCS Share API responses for files. However in its current form it looks weird and clutters the response. Especially since it is only usable for the web front end.

I propose to remove the functionality from the OCS Share API and to have the icon handling done in javascript. Since the OCS Share API does provide the mime type of the file. Some static javascript file should be good enough.

This should not be a problem since the functionality is not yet released. And make the API responses be useful on all platforms again.

CC: @MorrisJobke @DeepDiver1975 @karlitschek @schiesbn

@rullzer
Copy link
Contributor Author

rullzer commented May 22, 2015

Also it is weird that the icon field is not present when a single share is retrieved.

@oparoz
Copy link
Contributor

oparoz commented May 23, 2015

A duplicate of #14431 ?

@ghost ghost modified the milestones: 8.2-next, 8.1-current Jun 14, 2015
@oparoz oparoz added the dev:ocs label Jun 25, 2015
@rullzer
Copy link
Contributor Author

rullzer commented Jul 7, 2015

Fixed with #16724

@rullzer rullzer closed this as completed Jul 7, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants