Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag experimental apps as experimental before they are installed #17592

Closed
MightyCreak opened this issue Jul 12, 2015 · 13 comments

Comments

Projects
None yet
6 participants
@MightyCreak
Copy link

commented Jul 12, 2015

Steps to reproduce

  1. Fresh install of ownCloud 8.1
  2. Activate Contacts or Calendar apps (that are flagged "official", it's green, it seems perfect)
  3. See in the activated apps that in fact they are experimental

Expected behaviour

If an app is just flagged "official" and green, you expect it to be stable for the current ownCloud version.

If an app is "experimental", it should be flagged so before you install it.

Actual behaviour

The contacts and Calendar app is flagged "Experimental" only once you activated them, so it's a unwanted surprise.

Server configuration

Operating system: Debian 8.1

Web server: nginx 1.6.2

Database: mysql 5.5.43

PHP version: 5.6.7

ownCloud version: 8.1.0

Updated from an older ownCloud or fresh install: From and older ownCloud (8.0)

List of activated apps:

Enabled:
 - calendar: 0.7.2
 - contacts: 0.4.0.0
 - files: true
 - files_locking: 
 - files_pdfviewer: 0.7
 - files_sharing: 0.6.2
 - files_texteditor: 0.4
 - files_trashbin: 0.6.3
 - files_versions: 1.0.6
 - files_videoviewer: 0.1.3
 - firstrunwizard: 1.1
 - gallery: 0.6.0
 - provisioning_api: 0.2
 - templateeditor: 0.1
Disabled:
 - files_external
 - user_external
 - user_ldap
 - user_webdavauth

The content of config/config.php:
Note: sudo -u www-data php occ config:list system --public doesn't work with OC 8.1: config namespace doesn't exist.

<?php
$CONFIG = array (
  'instanceid' => 'xxx',
  'passwordsalt' => 'xxx',
  'secret' => 'xxx',
  'trusted_domains' => 
  array (
    0 => 'xxx',
  ),
  'datadirectory' => '/var/www/owncloud/data',
  'overwrite.cli.url' => 'xxx',
  'dbtype' => 'mysql',
  'version' => '8.1.0.8',
  'dbname' => 'owncloud',
  'dbhost' => 'localhost',
  'dbtableprefix' => 'oc_',
  'dbuser' => 'owncloud',
  'dbpassword' => 'xxx',
  'logtimezone' => 'UTC',
  'installed' => true,
);

Are you using external storage, if yes which one: no

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Firefox 38.0.5

Operating system: Fedora 22

Logs

Web server error log

Nothing interesting regarding calendar. The errors are from previous tests I was doing.

ownCloud log (data/owncloud.log)

@karlitschek karlitschek added the bug label Jul 12, 2015

@karlitschek

This comment has been minimized.

Copy link
Member

commented Jul 12, 2015

Strange. @LukasReschke Can you have a look once you are back? :-)

@MightyCreak

This comment has been minimized.

Copy link
Author

commented Jul 12, 2015

Apparently @RealRancor have the same problem.

From IRC:

<RealRancor> They are also flagged experimental here at my installation
@PVince81

This comment has been minimized.

Copy link
Member

commented Jul 13, 2015

Maybe something is wrong with the code that retrieves the approval flag for already installed apps.
Note that it shows "Experimental" because the flag might be missing, and "Experimental" is the default.

@CRCinAU

This comment has been minimized.

Copy link

commented Jul 14, 2015

Also note that if there is a newer version of the application available (I use Calendar and Contacts as an example here), then the app will show as EXPERIMENTAL and there is no option in the web interface to upgrade the application.

To then install the newer app version, you need to log into the host via ssh and rm -fR apps/contacts apps/calendar - and then install the apps again.

There really should be an "Upgrade" option - and it may well be the same problem as this bug causing it to go screwy.

@ghost

This comment has been minimized.

Copy link

commented Jul 14, 2015

@CRCinAU I think you have a different issue here as i got the update buttons from 0.7.0 to 0.7.1 and then to 0.7.2 even if the calendar was flagged experimental. I its probably the best to create a new issue for this using the issue template.

@PVince81

This comment has been minimized.

Copy link
Member

commented Jul 14, 2015

I see that there might be even another problem: if you disable the app store in the config under "appstoreenabled => false", then OC will not be able to retrieve the app levels of approval from the app store.

Maybe if the app store is disabled, the apps should simply not be shown as experimental at all ? (remove the warning) In such cases it means people already manually installed apps from git/tarballs.

@Gomez

This comment has been minimized.

Copy link
Member

commented Jul 16, 2015

👍 for @PVince81 suggestion.
I dont use the appstore and have disabled it in the config. With this settings it should ignore the experimental flag stuff.
Should i open a new ticket for this usecase or can we track it here?

@ghost

This comment has been minimized.

Copy link

commented Jul 19, 2015

Possible fix in: #17689 ?

@ghost

This comment has been minimized.

Copy link

commented Jul 21, 2015

Mhhh, at my installation its seems that this is no fixed by correctly flagging the Calendar and Contacts app at the appstore. Now both apps appears as "checked" instead of "flagged".

@PVince81

This comment has been minimized.

Copy link
Member

commented Mar 1, 2016

Is this still happening in 8.2.3 ?

@enoch85

This comment has been minimized.

Copy link
Member

commented May 24, 2016

Is this still happening in 9.0.2?

@MightyCreak

This comment has been minimized.

Copy link
Author

commented May 24, 2016

Didn't have the bug again, but maybe it is because Contacts and Calendar and considered stable now, so it never is considered experimental anymore...

@enoch85

This comment has been minimized.

Copy link
Member

commented May 24, 2016

Ok, I close this then. Feel free to reopen if it happens again.

@enoch85 enoch85 closed this May 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.