Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details view is unuseful for deleted files #19506

Closed
davitol opened this issue Oct 1, 2015 · 8 comments · Fixed by #19647
Closed

Details view is unuseful for deleted files #19506

davitol opened this issue Oct 1, 2015 · 8 comments · Fixed by #19647

Comments

@davitol
Copy link
Contributor

davitol commented Oct 1, 2015

Steps to reproduce

  1. Delete a file
  2. Go to the trashbin
  3. Click on details of the file deleted

Expected behaviour

Details view makes nonsense for deleted files or previous activities should be shown

Actual behaviour

Details view is available and shows the sidebar

Server configuration

Operating system:
Ubuntu 14.04

Web server:
Apache

Database:
MySQL

PHP version:
5.5.9

ownCloud version: ownCloud Enterprise Edition 8.2 beta1 (daily) Build:2015-10-01T03:09:06+00:00 d6e3195

Updated from an older ownCloud or fresh install:
Fresh

The content of config/config.php:


Are you using external storage, if yes which one: local/smb/sftp/...
No

Are you using encryption:
No

Logs

Client configuration

browser
Firefox

@davitol davitol added this to the 8.2-current milestone Oct 1, 2015
@davitol davitol modified the milestones: 8.2.1-next-maintenance, 8.2-current Oct 1, 2015
@PVince81
Copy link
Contributor

PVince81 commented Oct 7, 2015

It seems the activity app isn't able to retrieve activities for deleted files, it might be on purpose @nickvergessen ?

Regardless of activities, the sidebar can also show the bigger thumbnail, which can be useful too.

@nickvergessen
Copy link
Contributor

Activity sidebar is empt, because the file id is not send in the request, will have a closer look

@nickvergessen
Copy link
Contributor

data-id="0" is empty in the trashbin

@PVince81
Copy link
Contributor

PVince81 commented Oct 8, 2015

Okay, I'll have a look then

@PVince81 PVince81 self-assigned this Oct 8, 2015
@PVince81
Copy link
Contributor

PVince81 commented Oct 8, 2015

Looks like we don't have access to the file id because the trashbin contents is read directly from the disk... it would require additional database queries to find the matching file id. (CC @schiesbn)

@PVince81
Copy link
Contributor

PVince81 commented Oct 8, 2015

Ok, let's go the other route: remove the sidebar in the trashbin and then invest a bit of time later to make it useful.

@PVince81
Copy link
Contributor

PVince81 commented Oct 8, 2015

PR is here #19647

@PVince81
Copy link
Contributor

PVince81 commented Oct 8, 2015

Raised #19649 to look into the data-id / activities at some point

@MorrisJobke MorrisJobke modified the milestones: 9.0-next, 8.2.1-next-maintenance Oct 14, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants