Redirect loop on session timeout when exploring trashbin #21140

Closed
PVince81 opened this Issue Dec 11, 2015 · 3 comments

Projects

None yet

4 participants

@PVince81
Collaborator

Steps

  1. Create a folder "test"
  2. Delete the folder "test"
  3. Go to "Deleted files"
  4. Go to "/var/lib/php5" on the system and delete the session
  5. Enter the folder "test" inside the trashbin

Expected result

Login page shown

Actual result

File list tries to redirect to the root folder but then it fails too then redirects back to the subfolder.
Not sure why... there is some redirecting code in the main FileList implementation.

Versions

OC 8.2.1 and master. Very likely to exist in previous versions too (it's an oldie).

@PVince81 PVince81 self-assigned this Dec 11, 2015
@PVince81 PVince81 added this to the 9.0-current milestone Dec 11, 2015
@PVince81
Collaborator

Still happening on 9.0beta1

@PVince81
Collaborator
PVince81 commented Mar 2, 2016

The symptoms are now different, at least not as bad as before.

Still, the server is returning a 401 http status code. Why isn't it caught by the global ajaxError handler ??

@PVince81
Collaborator
PVince81 commented Mar 2, 2016

Okay, turns out our callback is called before the error handler, so need to return false to not break the callback chain.

Fix is here #22785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment