Object of class OC\\Connector\\Sabre\\Directory could not be converted to string #21230

Closed
MorrisJobke opened this Issue Dec 16, 2015 · 1 comment

Projects

None yet

3 participants

@MorrisJobke
Member
{"reqId":"LrktWybwli\/kyKS3yogp","remoteAddr":"172.26.112.16","app":"PHP","message":"Object of class OC\\Connector\\Sabre\\Directory could not be converted to string at \/var\/www\/owncloud\/lib\/private\/connector\/sabre\/objecttree.php#191","level":3,"time":"2015-12-11T13:33:31+00:00"}

Instead it should be something like `Could not copy directory PATH, target exists'.

bildschirmfoto 2015-12-16 um 14 15 19

cough @icewind1991 cough (please fix it - I don't know how to get a path out of an ICollection 🙈 )

fe0de5f#diff-bad86217951709753766eabf0f82deacR62 ;)

This is the line on current master:
https://github.com/owncloud/core/blob/aa6230e389b9756fc4cdb0e6b382281a762ddf74/apps/dav/lib/connector/sabre/objecttree.php#L193

Or @deepdiver1975 or @PVince81

@MorrisJobke MorrisJobke added this to the 9.0-current milestone Dec 16, 2015
@PVince81
Collaborator

I think it should be $sourceNode->getName() or something... seems this error case hasn't been tested.

@MorrisJobke MorrisJobke added a commit that referenced this issue Dec 16, 2015
@MorrisJobke MorrisJobke add unit test for #21230 89233ca
@MorrisJobke MorrisJobke removed their assignment Dec 16, 2015
@MorrisJobke MorrisJobke added a commit that referenced this issue Dec 16, 2015
@MorrisJobke MorrisJobke add unit test for #21230 6e3648c
@MorrisJobke MorrisJobke added a commit that referenced this issue Dec 16, 2015
@MorrisJobke MorrisJobke add unit test for #21230 6f6bf26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment