Renaming and moving displays an error in public shared folder with edit permissions. #21678

Closed
SergioBertolinSG opened this Issue Jan 13, 2016 · 7 comments

Projects

None yet

4 participants

@SergioBertolinSG
Member

Steps to reproduce

  1. Public share a folder, Allow editing.
  2. Using another browser without login, try to rename a file.
    or
  3. Using another browser without login, try to move a file to another folder.

Expected behaviour

Files are renamed or moved.

Actual behaviour

Error is displayed.

Server configuration

Operating system:
Ubuntu 14.04

Web server:
Apache

Database:
MySQL

PHP version:
5.5.9

ownCloud version: (see ownCloud admin page)
Using enterprise theme.
{"installed":true,"maintenance":false,"version":"9.0.0.6","versionstring":"9.0 pre alpha","edition":"Enterprise"}
(current master)

Updated from an older ownCloud or fresh install:
Fresh

List of activated apps:
Default in enterprise edition.

The content of config/config.php:


Are you using external storage, if yes which one: local/smb/sftp/...
No

Are you using encryption:
No

@SergioBertolinSG SergioBertolinSG added this to the 9.0-current milestone Jan 13, 2016
@DeepDiver1975
Member

Error is displayed and operation doesn't happen.

which one?

@SergioBertolinSG
Member

OK, edit, the operation actually happens.

It just displays an error.

When moving Could not move {filename}
When renaming Could not rename {filename}

Some logs:

{"reqId":"0hkNUqyR6HVPdmtfsHgs","remoteAddr":"HIDED_IP","app":"admin_audit","message":"Rename \"\/admin\/files\/Photos\/San Francisco.jpg\" to \"\/admin\/files\/Photos\/FOLDEREXTRA\/San Francisco.jpg\" by IP HIDED_IP, owner: admin [CLIENT_IP: HIDED_IP]","level":1,"time":"2016-01-13T09:56:17+00:00","method":"MOVE","url":"\/public.php\/webdav\/San%20Francisco.jpg"}
{"reqId":"0hkNUqyR6HVPdmtfsHgs","remoteAddr":"HIDED_IP","app":"PHP","message":"Call to a member function get() on a non-object at \/opt\/owncloud\/apps\/files_sharing\/lib\/updater.php#76","level":3,"time":"2016-01-13T09:56:17+00:00","method":"MOVE","url":"\/public.php\/webdav\/San%20Francisco.jpg"}
@SergioBertolinSG SergioBertolinSG changed the title from Rename and move is not possible in public shared folder with edit permissions. to Renaming and moving displays an error in public shared folder with edit permissions. Jan 13, 2016
@DeepDiver1975
Member

Call to a member function get() on a non-object at /opt/owncloud/apps/files_sharing/lib/updater.php#76","level":3,"time":"2016-01-13T09:56:17+00:00","method":"MOVE","url":"/public.php/webdav/San%20Francisco.jpg

that's the one ...

@rullzer @icewind1991 @schiesbn mind having a look? THX

@SergioBertolinSG SergioBertolinSG referenced this issue in owncloud/QA Jan 13, 2016
Closed

Testing WebDav in the browser. #69

@rullzer
Contributor
rullzer commented Feb 5, 2016

@SergioBertolinSG could you retry... all seems to work overhere on master now.

@SergioBertolinSG
Member

@rullzer tested on current master, is still happening exactly the same way.

@rullzer
Contributor
rullzer commented Feb 5, 2016

ah mmm I see I get errors in the transfer log... but no error indicating otherwise... anyway I'll look into it

@rullzer rullzer self-assigned this Feb 5, 2016
@rullzer rullzer added a commit that referenced this issue Feb 5, 2016
@rullzer rullzer Gracefull handle link shares rename hook
Fixes #21678

The hook is called on all renames. However when we use a link share
the getUserFolder fails. We now just opt out.
f4edfb6
@rullzer
Contributor
rullzer commented Feb 5, 2016

PR in #22159

@PVince81 PVince81 added a commit that referenced this issue Mar 14, 2016
@rullzer @PVince81 rullzer + PVince81 Gracefull handle link shares rename hook
Fixes #21678

The hook is called on all renames. However when we use a link share
the getUserFolder fails. We now just opt out.
1acc045
@PVince81 PVince81 added a commit that referenced this issue Mar 14, 2016
@rullzer @PVince81 rullzer + PVince81 Gracefull handle link shares rename hook
Fixes #21678

The hook is called on all renames. However when we use a link share
the getUserFolder fails. We now just opt out.
bf851e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment