Update sabre/dav to 2.1.9 and sabre/vobject to 3.5.0 for PHP7 compatibility #21914

Closed
ghost opened this Issue Jan 26, 2016 · 9 comments

Projects

None yet

5 participants

@ghost
ghost commented Jan 26, 2016

Just a short pointer as this was requested in https://github.com/owncloud/calendar/issues/1002

sabre/dav 2.1.9 including sabre/vobject 3.5.0 was released yesterday which should bring PHP7 compatibility into oC 8.x when updating to this release:

http://sabre.io/blog/2016/sabre-dav-2.1.9-release/

@rullzer
Contributor
rullzer commented Jan 26, 2016

Backporting 3rdparty updates is basically asking for troubles. Since so much can go wrong.

For 9.0 we are on 3.0.7 https://github.com/owncloud/3rdparty/blob/177daad35de835dafacc6e84f09e6335cc229a75/composer.json#L39

@DeepDiver1975
Member

Backporting 3rdparty updates is basically asking for troubles. Since so much can go wrong.

yes - but 2.1.9 was basically released for us to fix ownCloud 8.2.x on php7 😉

@nblock
Contributor
nblock commented Jan 26, 2016

+1

@rullzer
Contributor
rullzer commented Jan 26, 2016

@DeepDiver1975 ah ok... well then... let me prepare a 3rdparty update for 8.2... and pray nothing breaks...

@ghost
ghost commented Jan 26, 2016

@rullzer For sabre/vobject one compatibility breaking issue was introduced:

http://sabre.io/blog/2016/sabre-vobject-3.4.9-and-3.5.0-release/

No idea if the renamed classfiles are used within oC.

@DeepDiver1975
Member

No idea if the renamed classfiles are used within oC.

not as far as I'm aware of - we use vobjects 3.5.0 in master as well

@rullzer
Contributor
rullzer commented Jan 27, 2016

PR in #21938 please test

@rullzer rullzer self-assigned this Jan 27, 2016
@redhell
redhell commented Jan 27, 2016

#21938 works perfectly (Mac/iOS and Web)

PHP 7.0.2 w/MariaDB 10.1, redis

@rullzer
Contributor
rullzer commented Jan 29, 2016

PR is in => Closing

@rullzer rullzer closed this Jan 29, 2016
@ghost Unknown referenced this issue in v1r0x/polls Feb 25, 2016
Closed

clicking on the app-button ends on a blank page #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment