Password-link shares listed in "Shared in ... with ..." section of sidebar #22128

Closed
nickvergessen opened this Issue Feb 4, 2016 · 9 comments

Projects

None yet

5 participants

@nickvergessen
Contributor
Shared in test with 1|$2y$10$mLhrcvhKwViQqPcJx2.9rOpaIZa77lQhf3mhR0SpFJN7sei2e.lhS, test1

Steps

  1. Create a folder test
  2. Share test as link with password
  3. Create a folder test/test2
  4. Share test/test2 with user test1
  5. Open sharing dialog

Expected

Shared in test with test1

Actual

Shared in test with 1|$2y$10$mLhrcvhKwViQqPcJx2.9rOpaIZa77lQhf3mhR0SpFJN7sei2e.lhS, test1

@rullzer @PVince81

@PVince81
Collaborator
PVince81 commented Feb 4, 2016

Cannot reproduce on master 8994441
Opening the share dialog for the subdir doesn't contain any entries, neither for the owner nor the recipient.

@nickvergessen you set the 8.2 milestone, so does it mean it happens on 8.2.2 ? (no version field in your report). Let me try.

@PVince81
Collaborator
PVince81 commented Feb 4, 2016

Also cannot reproduce on v8.2.2, same result as master.

@nickvergessen did you miss a step maybe ?

@nickvergessen
Contributor

yes happens on stable8.2 and 8.2.2

Just did it again and it still reproduces. Note you have to set a password on the link share

@PVince81
Collaborator
PVince81 commented Feb 4, 2016

I did add a password on the link share. Maybe the order is different ?

I'll check that code anyway.

@PVince81 PVince81 self-assigned this Feb 4, 2016
@PVince81 PVince81 added the bug label Feb 17, 2016
@PVince81 PVince81 assigned rullzer and unassigned PVince81 Mar 18, 2016
@PVince81
Collaborator

@rullzer can you have a look ?

@rullzer
Contributor
rullzer commented Mar 18, 2016

@nickvergessen mmm this does not happen at my instance...

@nickvergessen
Contributor

Updated steps still work on stable8.2

  1. Create a folder test
  2. Share test as link with password
  3. Create a folder test/test2
  4. Share test/test2 with user test1
  5. Open sharing dialog
@rullzer
Contributor
rullzer commented Mar 21, 2016

Ah yet got it now...
Will fix.

@rullzer rullzer added a commit that referenced this issue Mar 21, 2016
@rullzer rullzer Do not show hash if parent is shared by link
fixes #22128

Since we store the password in the shared_with field of the database we
need to do some extra processing not to show it.
9dbad5a
@rullzer rullzer added a commit that referenced this issue Mar 21, 2016
@rullzer rullzer Do not show hash if parent is shared by link
fixes #22128

Since we store the password in the shared_with field of the database we
need to do some extra processing not to show it.
22ca4c5
@rullzer rullzer closed this Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment