It is not possible to unshare or delete an accepted federated folder #22483

Closed
nasli opened this Issue Feb 17, 2016 · 8 comments

Projects

None yet

5 participants

@nasli
nasli commented Feb 17, 2016

Steps to reproduce

1.User server A share a folder with user folder B
2.User B accept federated sharing
3.User A delete the folder

Expected behaviour

It is possible to delete o unshare the federated folder accepted

Actual behaviour

Not is possible to delete o unshare the federated folder accepted

Server configuration

{"installed":true,"maintenance":false,"version":"8.2.2.2","versionstring":"8.2.2","edition":""}
{"installed":true,"maintenance":false,"version":"9.0.0.11","versionstring":"9.0 beta 1","edition":""}

@PVince81 PVince81 added this to the 9.0-current milestone Feb 17, 2016
@PVince81
Collaborator

@rullzer @schiesbn

@rullzer
Contributor
rullzer commented Feb 18, 2016

Mmmm this seems to be a result of moving to webdav. Since we try to get the node for the folder. Which does not exists so we throw an error before we can do the actual delete....

@PVince81
Collaborator

One step is missing: User A must delete the folder from the trash bin.
Else the share info still exists.

However even in this case, User B still sees the folder. Navigating into the folder must make it disappear.

The bug is that Server A must return StorageInvalid not StorageNotAvailable

@PVince81
Collaborator

Actually, no. The shareinfo.php call must tell that the share is gone.

@PVince81
Collaborator

Okay, I think I got it, the share entry still exists:

+----+------------+--------------------------+-----------+---------------+--------+-----------+-------------+-------------+-------------+-------------+-------------+------------+----------+------------+-----------------+-----------+
| id | share_type | share_with               | uid_owner | uid_initiator | parent | item_type | item_source | item_target | file_source | file_target | permissions | stime      | accepted | expiration | token           | mail_send |
+----+------------+--------------------------+-----------+---------------+--------+-----------+-------------+-------------+-------------+-------------+-------------+------------+----------+------------+-----------------+-----------+
|  1 |          6 | user1@localhost/owncloud | root      | root          |   NULL | folder    | 8           | NULL        |           8 |             |           7 | 1455792080 |        0 | NULL       | 4XaoK5wPvt22QDO |         0 |
+----+------------+--------------------------+-----------+---------------+--------+-----------+-------------+-------------+-------------+-------------+-------------+------------+----------+------------+-----------------+-----------+
1 row in set (0.00 sec)

Now let's run cron to clean it up...

@PVince81
Collaborator

And POOF the share entry is gone.

And yet... User B still cannot get rid of it.

Steps so far:

  1. User 1 shares folder "test" with User 2 with fed sharing
  2. User 2 accepts the share
  3. User 1 deletes the folder "test"
  4. User 1 empties trashbin
  5. System runs cron.php to make sure the share gets cleant up (invalid file id)
  6. User 2 enters folder "test"

Actual: The folder is still there "storage not available"
Expected: The folder disappears after entering with "storage invalid".

Still looks like a bug in the 404 detection.

@PVince81 PVince81 self-assigned this Feb 18, 2016
@PVince81
Collaborator

Fix is here #22498

@PVince81 PVince81 added the sev2-high label Feb 18, 2016
@cmonteroluque cmonteroluque changed the title from Not is possible to unshare o delete a federated folder accepted to It is not possible to unshare or delete an accepted federated folder Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment