backgroundScan must ignore root storage #22501

Closed
PVince81 opened this Issue Feb 18, 2016 · 2 comments

Projects

None yet

4 participants

@PVince81
Collaborator

The Scanner::backgroundScan routine retrieves ALL mounts of the current user and rescans them.

It doesn't make sense to scan the root storage (data dir) in this case so it must be excluded.
This has resulted in issues in some envs where it would also scan all user's homes and store them in the root storage.

Additionally, we might also want to exclude the user's home storage and limit the scanning to external storages ?

@icewind1991 @LukasReschke @MorrisJobke @butonic

@PVince81 PVince81 added this to the 9.0-current milestone Feb 18, 2016
@PVince81
Collaborator

This only seems to happen if there are already entries that have a size of "-1" inside the root storage.
You need to upgrade from 8.0 where occ files:scan ran once to have a few entries there.

@PVince81 PVince81 assigned Morl0ck and MorrisJobke and unassigned Morl0ck Feb 18, 2016
@MorrisJobke MorrisJobke added a commit that referenced this issue Feb 22, 2016
@MorrisJobke MorrisJobke Avoids scanning the root storage
This check will skip the background scan for the root storage
because there is nothing in the root storage that isn't already
in another (mostly user-) storage.

An `instanceof` check could not be done because the storage
is wrapped multiple times and needs to be unwrapped to be
properly checked.

Fixes #22501
1878522
@MorrisJobke
Member

Fix is in #22565

@MorrisJobke MorrisJobke added a commit that referenced this issue Feb 22, 2016
@MorrisJobke MorrisJobke Avoids scanning the root storage
This check will skip the background scan for the root storage
because there is nothing in the root storage that isn't already
in another (mostly user-) storage.

Fixes #22501
8c77fde
@MorrisJobke MorrisJobke removed their assignment Feb 24, 2016
@MorrisJobke MorrisJobke added a commit that referenced this issue Feb 24, 2016
@MorrisJobke MorrisJobke Avoids scanning the root storage
This check will skip the background scan for the root storage
because there is nothing in the root storage that isn't already
in another (mostly user-) storage.

Fixes #22501
60ff1de
@MorrisJobke MorrisJobke added a commit that referenced this issue Feb 24, 2016
@MorrisJobke MorrisJobke Avoids scanning the root storage
This check will skip the background scan for the root storage
because there is nothing in the root storage that isn't already
in another (mostly user-) storage.

Fixes #22501
963c3aa
@MorrisJobke MorrisJobke removed their assignment Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment