IE public page footer appears in the middle #22560

Closed
PVince81 opened this Issue Feb 22, 2016 · 3 comments

Projects

None yet

3 participants

@PVince81
Collaborator

On stable8.2 (with scrolling fixes applied) and also on master, the footer appears in the middle of the public page in IE9-11:

ie-public-footer

It seems it's because in IE the actual height of the "content-wrapper" is still the same as the window, whereas in Firefox/Chrome the actual height adjusts to the list's total height (so the content-wrapper height is bigger than the page and causes scrolling).

Not sure how to make IE behave the same...

In general it feels like the current approach is wrong and likely to break.
A more surefire approach would be to have two CSS classes: one when scrolling is there and one when not, and use JS to interchange these CSS classes. Goal is to make the footer appear at the bottom of the page whenever there is not enough content. However, as soon as scrolling is available, the footer's layout must change to appear at the bottom of the scrolling list.
But this would be a bigger change and likely to break other things like PDF viewer, etc...

@PVince81 PVince81 added this to the 9.0-current milestone Feb 22, 2016
@PVince81
Collaborator

Ok, I'm onto something... seems like the good old "hasLayout" problem...

PR incoming.

@PVince81
Collaborator

Fix is here #22561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment