Files Sidebar shows no entries #22980

Closed
blizzz opened this Issue Mar 9, 2016 · 7 comments

Projects

None yet

3 participants

@blizzz
Contributor
blizzz commented Mar 9, 2016

Steps to reproduce

  1. Update to 9.0
  2. Go to Files
  3. Click on "Shared with you" in the left sidebar

Expected behaviour

Files shared with you do appear

Actual behaviour

"Nothing shared with you yet". However, in the default view, they appear. Log output:

{"reqId":"Ofw+\/U2oFGh7wP6x9G6L","remoteAddr":"92.200.128.123","app":"PHP","message":"OC\\Share20\\Exception\\InvalidShare:  at \/path\/to\/owncloud\/lib\/private\/share20\/defaultshareprovider.php#783","level":3,"time":"2016-03-09T01:14:16+00:00"}

Server configuration

Operating system: Ubuntu 14.04

Web server: Apache2

Database: MySQL

PHP version: 5.5.9

ownCloud version: 9.0.0

Updated from an older ownCloud or fresh install: upgrade

Where did you install ownCloud from: tarballs

Signing status (ownCloud 9.0 and above): awesome

Are you using external storage, if yes which one: no

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Firefox 44

Operating system: Antergos Linux

Logs

ownCloud log (data/owncloud.log)

{"reqId":"Ofw+\/U2oFGh7wP6x9G6L","remoteAddr":"92.200.128.123","app":"PHP","message":"OC\\Share20\\Exception\\InvalidShare:  at \/path\/to\/owncloud\/lib\/private\/share20\/defaultshareprovider.php#783","level":3,"time":"2016-03-09T01:14:16+00:00"}

@rullzer

@blizzz blizzz added this to the 9.0.1-next-maintenance milestone Mar 9, 2016
@rullzer
Contributor
rullzer commented Mar 9, 2016

I'm not sure why you code would actually follow that path. Could you send me a dump of your oc_share table? Seems the migration did not finish its job...

@blizzz
Contributor
blizzz commented Mar 9, 2016

@rullzer Shared to you

@rullzer
Contributor
rullzer commented Mar 9, 2016

Ok I think I know why... the SQL queries are not narrow enough and they pick up your shared calendar and contacts... let me prepare a patch...

@rullzer
Contributor
rullzer commented Mar 9, 2016

Possible fix in #23008 please have a look. The patch is pretty simple

@rullzer rullzer added the sev2-high label Mar 9, 2016
@rullzer
Contributor
rullzer commented Mar 9, 2016

Fixed with #23008
Backport to stable9 in #23016

@rullzer rullzer closed this Mar 9, 2016
@blizzz
Contributor
blizzz commented Mar 9, 2016

For the record, the sections "Shared with others" and "Shared by link" did not work, because of bogus entries in the share table. Basically link shares without token. Very likely they origin from a very early improper migration (the instance exists since OC 4, at least, and those shares were from 2012). Since those links don't work anymore, deleting them from the DB fixed the issue: delete from share where share_type = '3' and token is null; The token was not present already before upgrading to OC 9. Repair step is a candidate.

@Kawohl
Contributor
Kawohl commented Mar 10, 2016

had the same here on fresh installs on opensuse leap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment