Open sidebar when clicking in the right part of rows in files view #23381

Closed
SergioBertolinSG opened this Issue Mar 18, 2016 · 8 comments

Projects

None yet

5 participants

@SergioBertolinSG
Member

Steps to reproduce

  1. Having a file or folder uploaded, try to open sidebar clicking at the right of the three dots.

Expected behaviour

Sidebar opens.

I'd expect specially that the sidebar opens in the orange area:

screen shot 2016-03-18 at 08 59 22

But perhaps it is interesting to allow opening sidebar in the pink area as well.

Actual behaviour

Nothing happens.

@SergioBertolinSG SergioBertolinSG added this to the 9.1-current milestone Mar 18, 2016
@PVince81 PVince81 added the junior job label Mar 18, 2016
@PVince81
Collaborator

setting to junior job, should be a matter of adjusting the click selector

@jancborchardt
Member

Yup! Just for the record I support this. ;) And it seems a great junior job.

@ErikPel
Member
ErikPel commented Mar 23, 2016

I just checked it out and got it working. Right now it opens the sidebar on the size and date fields but not the share and ellipsis button. Is this enough or should I include those two as well?

@jancborchardt @SergioBertolinSG

@SergioBertolinSG
Member

@ErikPel what about the orange section in the picture?

@ErikPel
Member
ErikPel commented Mar 23, 2016

@SergioBertolinSG like half way but the other half is taken by the ellipsis button padding. I could get it working by taking the right padding off the ellipsis button and adding it into padding-left of the size part but thought I'd ask first if there is a better way. Feels really dirty doing such thing for simple change like this.

@SergioBertolinSG
Member

@ErikPel ok, could you prepare a PR so we can test/review it?.

@jancborchardt
Member

@ErikPel do you want to be added to the owncloud-designers team? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment