Federated sharing: volatile edit permission #24032

Closed
michaelstingl opened this Issue Apr 15, 2016 · 7 comments

Projects

None yet

4 participants

@michaelstingl
michaelstingl commented Apr 15, 2016 edited

Steps to reproduce

  1. Create federated share with no edit permission
  2. Then grant edit permission later

Expected behaviour

Edit permission should be permanent

Actual behaviour

Edit permission don't get saved permanent. (after switching to Favorites section or reloading the page)

federated-sharing-edit-permission

Server configuration

Ubuntu 14.04

Web server:
Apache

Database:
MySQL

PHP version:
PHP 5.5.9

ownCloud version: (see ownCloud admin page)
9.0.1

Updated from an older ownCloud or fresh install:
fresh install

Where did you install ownCloud from:

Signing status (ownCloud 9.0 and above):

No errors have been found.

List of activated apps:

# sudo -u www-data php occ app:list
Enabled:
  - activity: 2.2.1
  - comments: 0.2
  - dav: 0.1.6
  - federatedfilesharing: 0.1.0
  - federation: 0.0.4
  - files: 1.4.4
  - files_pdfviewer: 0.8
  - files_sharing: 0.9.1
  - files_texteditor: 2.1
  - files_trashbin: 0.8.0
  - files_versions: 1.2.0
  - files_videoplayer: 0.9.8
  - firstrunwizard: 1.1
  - gallery: 14.5.0
  - notifications: 0.2.3
  - provisioning_api: 0.4.1
  - systemtags: 0.2
  - templateeditor: 0.1
  - updatenotification: 0.1.0
Disabled:
  - encryption
  - external
  - files_external
  - user_external
  - user_ldap

Are you using external storage, if yes which one: local/smb/sftp/...
no

Are you using encryption: yes/no
no

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
no

Client configuration

Browser:
Chrome 49

Operating system:
Mac OS X 10.11.4

Logs

no messages appear in the logs (owncloud.log and apache log).

@MorrisJobke

00005231

@michaelstingl

An user reported this for 8.2.3 too:

When you share a folder with someone, the default permission is to allow the receiver to write to the share. This seems to be represented by a 7 in the column "permissions" in oc_share. When the sharer changes this, the 7 changes to a 1. But when he tries to give back the write permissions and clicks on the box in the web interface (I think it is "can edit"), the permission in the database never changes back to 7. We saw this with owncloud 8.2.3

@MorrisJobke
Member

sounds like a JS bug - cc @rullzer @PVince81

@rullzer
Contributor
rullzer commented Apr 19, 2016

I think this will be fixed with #23918

@rullzer
Contributor
rullzer commented Apr 19, 2016

Aah but that of course won't help in 9.x... I'll see if there is a quick fix for this.

@rullzer rullzer self-assigned this Apr 19, 2016
@rullzer rullzer added a commit that referenced this issue Apr 20, 2016
@rullzer rullzer Allow setting can edit permissions on federated shares in webUI
Fixes #24032

Since we have a slightly different UI for the federated shares our
normal logic fails us. This makes sure to add the correct permissions
when it is a federated share.
9986413
@rullzer rullzer added a commit that referenced this issue Apr 20, 2016
@rullzer rullzer Allow setting can edit permissions on federated shares in webUI
Fixes #24032

Since we have a slightly different UI for the federated shares our
normal logic fails us. This makes sure to add the correct permissions
when it is a federated share.
466b7dc
@PVince81 PVince81 added this to the 9.0.2-current-maintenance milestone Apr 20, 2016
@PVince81
Collaborator

Setting to 9.0.2 since we have a PR ready to merge: #24108

@rullzer rullzer added a commit that referenced this issue Apr 20, 2016
@rullzer rullzer Allow setting can edit permissions on federated shares in webUI
Fixes #24032

Since we have a slightly different UI for the federated shares our
normal logic fails us. This makes sure to add the correct permissions
when it is a federated share.
c53acac
@rullzer
Contributor
rullzer commented Apr 20, 2016

Merged. Closing this

@rullzer rullzer closed this Apr 20, 2016
@MorrisJobke
Member

@michaelstingl This will also be fixed in 8.2.4 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment