Receiving a local share folder from two users deduplication broken #25244

Closed
PVince81 opened this Issue Jun 23, 2016 · 7 comments

Projects

None yet

2 participants

@PVince81
Collaborator

Steps

  1. Create three users "user1", "user2", "user3"
  2. As "user1" create a folder "test" with a file "test/one.txt" inside
  3. Share "test" with "user3"
  4. As "user2" create a folder "test" with a file "test/two.txt" inside
  5. Share "test" with "user3"
  6. Login as "user3"

Expected result

Two folders "test" and "test (2)"

Actual result

Only a folder "test" with "two.txt" inside, from user2

Versions

ownCloud 9.0.2

@owncloud/sharing @owncloud/filesystem regression

@PVince81 PVince81 added this to the 9.0.3-current-maintenance milestone Jun 23, 2016
@PVince81
Collaborator

Looks like the deduplication code with "moveShare" isn't triggered at all.

@PVince81
Collaborator

CC @owncloud/qa we need tests for such cases

@rullzer
Contributor
rullzer commented Jun 23, 2016

See #25113

@PVince81
Collaborator

@rullzer okay, I think "deduplication" was used wrongly here. Basically we expect two folders to appear instead of one. It's the reverse from grouping.

I tried 9.0.3RC1 and the bug is still there.
However on master (af98e3e) it is fixed. Maybe a reverse bisect will help find out what to backport.

@rullzer
Contributor
rullzer commented Jun 23, 2016

O right... that is different...
mmmm the logic there should handle it... good to see that it is working on master...

@PVince81
Collaborator

I'll do a reverse bisect

@PVince81
Collaborator

Here we go, this commit fixes it on master: 411fac8 from this PR #23937

Looks like we missed a backport there. Will backport it.

@PVince81 PVince81 closed this Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment