Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
No feedback when changing passwords as administrator #25532
Steps to reproduce
I would expect some feedback if it worked or not.
No feedback shown.
Operating system: CentOS Linux release 7.2.1511 (Core)
Web server: Apache/2.4.6 (CentOS)
PHP version: PHP 5.5.37
ownCloud version: 9.0.3 (stable)
Updated from an older ownCloud or fresh install: upgrade from 9.0.1 (stable)
Where did you install ownCloud from: yum
List of activated apps:
The content of config/config.php:'de', 'updatechecker' => false, 'instanceid' => '...', 'passwordsalt' => '...', 'secret' => '...', 'trusted_domains' => array ( 0 => '...', 1 => '...', ), 'datadirectory' => '/srv/owncloud-data/', 'overwrite.cli.url' => '...', 'dbtype' => 'mysql', 'version' => '22.214.171.124', 'dbname' => '...', 'dbhost' => '...', 'dbtableprefix' => '...', 'dbuser' => '...', 'dbpassword' => '...', 'logtimezone' => 'Europe/Berlin', 'installed' => true, 'mail_from_address' => 'hostmaster', 'mail_smtpmode' => 'php', 'mail_domain' => '...', 'singleuser' => false, 'appstore.experimental.enabled' => true, 'enabledPreviewProviders' => array ( 0 => 'OC\Preview\PNG', 1 => 'OC\Preview\JPEG', 2 => 'OC\Preview\GIF', 3 => 'OC\Preview\BMP', 4 => 'OC\Preview\XBitmap', 5 => 'OC\Preview\MP3', 6 => 'OC\Preview\TXT', 7 => 'OC\Preview\MarkDown', 8 => 'OC\Preview\PDF', ), 'theme' => '', 'loglevel' => 2, 'maintenance' => false, 'htaccess.RewriteBase' => '/owncloud', 'theme' => '...', 'preview_libreoffice_path' => '/usr/bin/libreoffice', ); ?>
Are you using external storage, if yes which one: local/smb/sftp/...
Are you using encryption: yes/no
Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
I have identified the solution for the above issue. Should I go ahead and create a pull request?
I suggest to use the i18n-version of "Password changed successfully!" to allow the translation of this string. Furthermore keep in mind, that the Server might respond with a 500, e.g. when the private key for the user is missing. In this case I am quite sure, that you do not get the proper
I have an active pull request with this fix. I would suggest not having the != success in the IF statement. If something goes wrong, we don't want to default back to displaying a success message in the ELSE.