New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot increase permissions #25542

Closed
thedudede opened this Issue Jul 20, 2016 · 7 comments

Comments

Projects
None yet
3 participants
@thedudede

thedudede commented Jul 20, 2016

When I try to change permissions I get the following error-message: (sorry partialy german)

"Fehler beim Teilen
Cannot increase permissions"

In english it should be "error sharing..."

The strange thing is: when I decrease the permissions it works fine. But increasing it afterwards leads to the error.
When I completly remove the permission and grant it again, the user has full access again.

ownCloud 9.0.3 (stable) running under ubuntu 16

Update:
I have just updated to 9.0.4-1.1
but still the same issue

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Jul 21, 2016

Member

Can you give more information on your sharing situation ? Who shares what with whom with what permissions ? Also include the reshares if there are any.

And then, who is trying to change the permissions to cause this error ?

Member

PVince81 commented Jul 21, 2016

Can you give more information on your sharing situation ? Who shares what with whom with what permissions ? Also include the reshares if there are any.

And then, who is trying to change the permissions to cause this error ?

@thedudede

This comment has been minimized.

Show comment
Hide comment
@thedudede

thedudede Jul 21, 2016

it's a "fresh" system.
only 2 users and one group so far
The admin-user shares with a group.

But let me try, if sharing with the user leads to the same problem.
well that's strange... sharing with the user works normally...

next trial:
I will login with the user and share with the group.
the same behaviour..
(sharing with user works normally, but increasing the access-rights for the group fails)

thedudede commented Jul 21, 2016

it's a "fresh" system.
only 2 users and one group so far
The admin-user shares with a group.

But let me try, if sharing with the user leads to the same problem.
well that's strange... sharing with the user works normally...

next trial:
I will login with the user and share with the group.
the same behaviour..
(sharing with user works normally, but increasing the access-rights for the group fails)

@marciofoz

This comment has been minimized.

Show comment
Hide comment
@marciofoz

marciofoz Aug 26, 2016

Hi, I use OC 9.1 and have the same problem.
To reproduce:
The user (the group admin) create the folder with all permissions and share the folder with the same group. Then the same user remove all permissions and try select any permission again. Then I see the message "Cannot increase permissions".
I can make a small video if necessary.

marciofoz commented Aug 26, 2016

Hi, I use OC 9.1 and have the same problem.
To reproduce:
The user (the group admin) create the folder with all permissions and share the folder with the same group. Then the same user remove all permissions and try select any permission again. Then I see the message "Cannot increase permissions".
I can make a small video if necessary.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Aug 29, 2016

Member

My steps:

  1. Install OC v9.1.0
  2. Create a user "subadmin"
  3. Add "subadmin" to group "group1"
  4. Make "subadmin" a subadmin of group "group1"
  5. Login as "subadmin"
  6. Create a user "user1" in group "group1"
  7. Create a folder "test"
  8. Share "test" with "group1" with all permissions
  9. Remove permissions
  10. Re-add permissions

Expected: can readd permissions
Actual: "Cannot increase permissions"

Ouch. => regression

Member

PVince81 commented Aug 29, 2016

My steps:

  1. Install OC v9.1.0
  2. Create a user "subadmin"
  3. Add "subadmin" to group "group1"
  4. Make "subadmin" a subadmin of group "group1"
  5. Login as "subadmin"
  6. Create a user "user1" in group "group1"
  7. Create a folder "test"
  8. Share "test" with "group1" with all permissions
  9. Remove permissions
  10. Re-add permissions

Expected: can readd permissions
Actual: "Cannot increase permissions"

Ouch. => regression

@PVince81 PVince81 added this to the 9.1.1 milestone Aug 29, 2016

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Aug 29, 2016

Member

Quick workaround is to unshare from "group1" then share again.

Member

PVince81 commented Aug 29, 2016

Quick workaround is to unshare from "group1" then share again.

@PVince81 PVince81 self-assigned this Aug 29, 2016

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Aug 29, 2016

Member

Okay, I think I see what the problem is: since the user who shares is also in the receiving group, the logic that checks the max allowed permissions is confused. But really, it should ignore the permissions since the user is the owner of the share.

Member

PVince81 commented Aug 29, 2016

Okay, I think I see what the problem is: since the user who shares is also in the receiving group, the logic that checks the max allowed permissions is confused. But really, it should ignore the permissions since the user is the owner of the share.

@PVince81 PVince81 referenced this issue Aug 29, 2016

Merged

Allow increasing permissions for share owner #25966

6 of 8 tasks complete
@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Aug 29, 2016

Member

Fix is here #25966

Member

PVince81 commented Aug 29, 2016

Fix is here #25966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment