Federated share doesn't retry after becoming available again #26037

Closed
PVince81 opened this Issue Sep 6, 2016 · 6 comments

Projects

None yet

1 participant

@PVince81
Collaborator
PVince81 commented Sep 6, 2016

Steps

  1. Setup OC_A and OC_B
  2. Login as admin@OC_B
  3. Share a folder "Photos" with admin@OC_A
  4. Login as admin@OC_A
  5. Accept the share
  6. Switch OC_B to maintenance mode
  7. Do a PROPFIND on OC_A as admin: curl -X PROPFIND http://admin:admin@localhost/owncloud/remote.php/webdav/Photos/ => 503 Storage Not Available
  8. Switch OC_B back to normal mode (remove maintenance mode)
  9. Do a PROPFIND on OC_A as admin: curl -X PROPFIND http://admin:admin@localhost/owncloud/remote.php/webdav/Photos/ => 503 Storage Not Available (which is ok within 10 minutes)
  10. Update the timestamp in OC_A's oc_storages to force a recheck: update oc_storages set last_checked=NULL;
  11. Do a PROPFIND on OC_A as admin: curl -X PROPFIND http://admin:admin@localhost/owncloud/remote.php/webdav/Photos/

Expected result

The recheck must find that the federated share is available again

Actual result

The recheck doesn't work properly. It writes back the value of "last_checked" but doesn't toggle the "availability" flag in "oc_storages"

Versions

Observed on 9.1 by @mmattel
Observed on master/9.2 pre-alpha by myself

@PVince81 PVince81 added this to the 9.2 milestone Sep 6, 2016
@PVince81 PVince81 self-assigned this Sep 6, 2016
@PVince81
Collaborator
PVince81 commented Sep 6, 2016

Let's debug this...

@PVince81 PVince81 modified the milestone: 9.1.1, 9.2 Sep 6, 2016
@PVince81
Collaborator
PVince81 commented Sep 6, 2016

Bääh... WTF... the result of parent::test() is not returned, so instead of true it's undefined... PR on the way.

@PVince81
Collaborator
PVince81 commented Sep 6, 2016

@owncloud/qa is there a way to automate this with integration tests ?

@PVince81 PVince81 referenced this issue Sep 6, 2016
Merged

Fix fed share test call to return proper result #26038

5 of 10 tasks complete
@PVince81
Collaborator
PVince81 commented Sep 6, 2016

Fix is here #26038

@PVince81
Collaborator
PVince81 commented Sep 6, 2016

QA ticket owncloud/QA#300

@PVince81
Collaborator
PVince81 commented Sep 6, 2016

stable9 is not affected, the code is also quite different there.

@PVince81 PVince81 closed this in #26038 Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment