FR: Do not show TwoFactor list, if only one exists #26134

Closed
cornelinux opened this Issue Sep 19, 2016 · 5 comments

Projects

None yet

2 participants

@cornelinux
Contributor

Steps to reproduce

  1. define only one twofactor provider
  2. login with owncloud credentials
  3. user needs to "select" the one provider from the list of one.

Expected behaviour

2FA is sometimes anoying for the user anyway. So if there is only one provider, he should not do the additional click to select the only provider. OC should not display the list with one entry but directly choose this provider. Save this additional click.

Actual behaviour

s.o.

Server configuration

Operating system: N/A

Web server: N/A

Database: N/A

PHP version: N/A

ownCloud version: (see ownCloud admin page) 9.1

Updated from an older ownCloud or fresh install: N/A

Where did you install ownCloud from: owncloud.org

Signing status (ownCloud 9.0 and above): ?

List of activated apps: privacyIDEA two factor provider

The content of config/config.php: N/A

Are you using external storage, if yes which one: N/A

Are you using encryption: no

Are you using an external user-backend, if yes which one: internal user DB

Client configuration

Browser: chrome

Operating system: Linux

@PVince81 PVince81 added this to the 9.1.2 milestone Sep 19, 2016
@PVince81
Collaborator

Hmm, indeed.

@PVince81
Collaborator

PR here #26141

@cornelinux mind helping to test it with your provider ?

@cornelinux
Contributor

@PVince81 what would be the recommended way to do this.
Where can I clone a branch or PR?

@PVince81
Collaborator

@cornelinux you could simply download the PR as patch if that's easier for you: https://github.com/owncloud/core/pull/26141.patch

@cornelinux
Contributor

Thx. I just tested it. Works like a charm with the privacyIDEA 2FA App. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment