New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Do not show TwoFactor list, if only one exists #26134

Closed
cornelinux opened this Issue Sep 19, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@cornelinux
Contributor

cornelinux commented Sep 19, 2016

Steps to reproduce

  1. define only one twofactor provider
  2. login with owncloud credentials
  3. user needs to "select" the one provider from the list of one.

Expected behaviour

2FA is sometimes anoying for the user anyway. So if there is only one provider, he should not do the additional click to select the only provider. OC should not display the list with one entry but directly choose this provider. Save this additional click.

Actual behaviour

s.o.

Server configuration

Operating system: N/A

Web server: N/A

Database: N/A

PHP version: N/A

ownCloud version: (see ownCloud admin page) 9.1

Updated from an older ownCloud or fresh install: N/A

Where did you install ownCloud from: owncloud.org

Signing status (ownCloud 9.0 and above): ?

List of activated apps: privacyIDEA two factor provider

The content of config/config.php: N/A

Are you using external storage, if yes which one: N/A

Are you using encryption: no

Are you using an external user-backend, if yes which one: internal user DB

Client configuration

Browser: chrome

Operating system: Linux

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Sep 19, 2016

Member

Hmm, indeed.

Member

PVince81 commented Sep 19, 2016

Hmm, indeed.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Sep 19, 2016

Member

PR here #26141

@cornelinux mind helping to test it with your provider ?

Member

PVince81 commented Sep 19, 2016

PR here #26141

@cornelinux mind helping to test it with your provider ?

@cornelinux

This comment has been minimized.

Show comment
Hide comment
@cornelinux

cornelinux Sep 19, 2016

Contributor

@PVince81 what would be the recommended way to do this.
Where can I clone a branch or PR?

Contributor

cornelinux commented Sep 19, 2016

@PVince81 what would be the recommended way to do this.
Where can I clone a branch or PR?

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Sep 19, 2016

Member

@cornelinux you could simply download the PR as patch if that's easier for you: https://github.com/owncloud/core/pull/26141.patch

Member

PVince81 commented Sep 19, 2016

@cornelinux you could simply download the PR as patch if that's easier for you: https://github.com/owncloud/core/pull/26141.patch

@cornelinux

This comment has been minimized.

Show comment
Hide comment
@cornelinux

cornelinux Sep 19, 2016

Contributor

Thx. I just tested it. Works like a charm with the privacyIDEA 2FA App. 👍

Contributor

cornelinux commented Sep 19, 2016

Thx. I just tested it. Works like a charm with the privacyIDEA 2FA App. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment