User cannot increase permissions on his own group share if he's inside the group

[ckamm]

ownCloud version: 9.0.5.2

Steps to reproduce

1. Set up such that you have a user A and a group G that contains A (like "admin" and "admin (group)")
2. As A, share something with group G using the web interface.
3. Remove the share or edit permission and try to re-add it.

Expected behaviour

It should work since A is the owner of the share.

Actual behaviour

The permissions cannot be added again. There's an error with status code 404 and the message "Cannot increase permissions".

Analysis

That's because the share is both incoming and outgoing for A and the permission-setting code in apps/files_sharing/lib/API/Share20OCS.php checks that one doesn't increase permissions for incoming shares. Therefore A cannot increase the permissions on his own share.

Related

The bug can also be triggered from the desktop client, see owncloud/client#5197

[SergioBertolinSG]

Is this specific of stable9 or happens also in master?

[SergioBertolinSG]

I've added an integration test for this case #26183

[davitol]

@SergioBertolinSG Milestone changed to 9.0.6 due to it cannot be reproduced in 9.1.1 version (in 9.1.0.15 i was able to reproduce it). So maybe there's a fix in 9.1.1 that IMHO should be backported to 9.0.6

[PVince81]

Okay, I'll backport #26045 to 9.0

[PVince81]

here you go #26187

[PVince81]

8.2.8 does not seem to be affected

[ckamm]

@PVince81 Duplicate of #25542?

[PVince81]

Yes. Now backported to 9.0.6 through #26187

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.