New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option for allowing or not autocompletion in the email field dialog when sharing. #26504

Closed
voundaries opened this Issue Oct 27, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@voundaries

voundaries commented Oct 27, 2016

When "Allow users to send mail notification for shared files" option is enabled on the settings, it shows the email field for link sharing.

When typing the email address for sharing, it autocompletes and also shows other users' id's and addresses registered on the server. This leaks info to admins and other users.

As mentioned by @xshadow on issue #24872 :

It would be nice to have the following features:

Give the administrators the opportunity to globally disable username autocompletion on sharing (in config/config.php)
Give the user the possibility to decide if he/she wants to be found or not (in the user settings)

Or
Add an option for allowing or not autocompletion in the email field dialog when sharing.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Oct 28, 2016

Member

Hmm, I think this should be made part of the existing option "Allow username autocompletion in share dialog. If this is disabled the full username needs to be entered."

Member

PVince81 commented Oct 28, 2016

Hmm, I think this should be made part of the existing option "Allow username autocompletion in share dialog. If this is disabled the full username needs to be entered."

@PVince81 PVince81 added this to the 9.1.3 milestone Oct 28, 2016

@PVince81 PVince81 added the junior job label Oct 28, 2016

IljaN added a commit to IljaN/core that referenced this issue Nov 6, 2016

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Nov 9, 2016

Member

PR here #26559

Member

PVince81 commented Nov 9, 2016

PR here #26559

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Nov 9, 2016

Member

The PR doesn't add a new option but reuses the existing one to also exclude email completion, that should be enough.

Member

PVince81 commented Nov 9, 2016

The PR doesn't add a new option but reuses the existing one to also exclude email completion, that should be enough.

@PVince81 PVince81 closed this Nov 9, 2016

IljaN added a commit to IljaN/core that referenced this issue Jan 17, 2017

Username autocomplete option in admin menue now also toggles autocomp…
…lete for email input (share by e-mail) #26504

(cherry picked from commit 861011c) (Backport: #1760)

IljaN added a commit to IljaN/core that referenced this issue Jan 17, 2017

Username autocomplete option in admin menue now also toggles autocomp…
…lete for email input (share by e-mail) #26504

(cherry picked from commit 861011c) Backport: #1760

IljaN added a commit to IljaN/core that referenced this issue Jan 17, 2017

Username autocomplete option in admin menue now also toggles autocomp…
…lete for email input (share by e-mail) #26504

(cherry picked from commit 861011c)

IljaN added a commit to IljaN/core that referenced this issue Jan 17, 2017

Username autocomplete option in admin menue now also toggles autocomp…
…lete for email input (share by e-mail) #26504

(cherry picked from commit 861011c)

elie195 added a commit to elie195/core that referenced this issue Mar 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment