Add an option for allowing or not autocompletion in the email field dialog when sharing. #26504

Closed
voundaries opened this Issue Oct 27, 2016 · 3 comments

Projects

None yet

2 participants

@voundaries

When "Allow users to send mail notification for shared files" option is enabled on the settings, it shows the email field for link sharing.

When typing the email address for sharing, it autocompletes and also shows other users' id's and addresses registered on the server. This leaks info to admins and other users.

As mentioned by @xshadow on issue #24872 :

It would be nice to have the following features:

Give the administrators the opportunity to globally disable username autocompletion on sharing (in config/config.php)
Give the user the possibility to decide if he/she wants to be found or not (in the user settings)

Or
Add an option for allowing or not autocompletion in the email field dialog when sharing.

@PVince81
Collaborator

Hmm, I think this should be made part of the existing option "Allow username autocompletion in share dialog. If this is disabled the full username needs to be entered."

@PVince81 PVince81 added this to the 9.1.3 milestone Oct 28, 2016
@PVince81 PVince81 added the junior job label Oct 28, 2016
@IljaN IljaN added a commit to IljaN/core that referenced this issue Nov 6, 2016
@IljaN IljaN Username autocomplete option in admin menue now also toggles autocomp…
…lete for email input (share by e-mail) #26504
861011c
@PVince81
Collaborator
PVince81 commented Nov 9, 2016

PR here #26559

@PVince81
Collaborator
PVince81 commented Nov 9, 2016

The PR doesn't add a new option but reuses the existing one to also exclude email completion, that should be enough.

@PVince81 PVince81 closed this Nov 9, 2016
@IljaN IljaN added a commit to IljaN/core that referenced this issue Jan 17, 2017
@IljaN @IljaN IljaN + IljaN Username autocomplete option in admin menue now also toggles autocomp…
…lete for email input (share by e-mail) #26504

(cherry picked from commit 861011c) (Backport: #1760)
c27b2b9
@IljaN IljaN added a commit to IljaN/core that referenced this issue Jan 17, 2017
@IljaN @IljaN IljaN + IljaN Username autocomplete option in admin menue now also toggles autocomp…
…lete for email input (share by e-mail) #26504

(cherry picked from commit 861011c) Backport: #1760
62b1865
@IljaN IljaN added a commit to IljaN/core that referenced this issue Jan 17, 2017
@IljaN @IljaN IljaN + IljaN Username autocomplete option in admin menue now also toggles autocomp…
…lete for email input (share by e-mail) #26504

(cherry picked from commit 861011c)
1b3cef6
@IljaN IljaN added a commit to IljaN/core that referenced this issue Jan 17, 2017
@IljaN @IljaN IljaN + IljaN Username autocomplete option in admin menue now also toggles autocomp…
…lete for email input (share by e-mail) #26504

(cherry picked from commit 861011c)
13bd433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment