Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Storage repair iterates over all LDAP users during upgrade #26774
we should iternate only over the known users
I just realized a flaw of this:
This repair was supposed to run only for installs that were created before OC 8.1 or so, then never run again thanks to this flag.
However this flag isn't set for new OC >= 8.1 new installs, so it would run at least for the very first upgrade. This is wrong.
One idea would be to kill that repair step completely in OC >= 8.1.
One commonly observed problem is that on some setups people ignored the warnings given by this repair step in case of unrepairable situations. Then the duplicate storages still exist up to current versions. (the duplicates could only have been created in OC < 8.0).
But with that reasoning, if the duplicates could not be fixed automatically, the repair step itself can still be removed from the codebase as it wouldn't be useful anyway in such situations.
However, the legacy storage fallback would still make sure that OC still works as before. There are discussions about removing the fallback as well, which is a much more risky change: #26325