New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload progress bar: wrong plural for German translation #26804

Closed
michaelstingl opened this Issue Dec 9, 2016 · 5 comments

Comments

Projects
None yet
6 participants
@michaelstingl

michaelstingl commented Dec 9, 2016

In the upload progress bar, German words use wrong plural.

Wrong:
Sekunde ==> Sekundes
Minute ==> Minutes
Stunde ==> Stundes

image001

Correct:
Sekunde ==> Sekunden
Minute ==> Minuten
Stunde ==> Stunden

Steps to reproduce

  1. Install 9.1.2
  2. Login and switch language to "German" on Personal page
  3. Upload large file

Expected behaviour

German UI should have correct plural.

Actual behaviour

German UI has incorrect plural.

Server configuration

ownCloud version: (see ownCloud admin page)
9.1.2

Where did you install ownCloud from:

Docker:
https://hub.docker.com/_/owncloud/

00006728

@hodyroff

This comment has been minimized.

Show comment
Hide comment
@hodyroff

hodyroff Dec 12, 2016

Contributor

fixed. You can do it in Transifex yourself ;) Please check in next daily.

Contributor

hodyroff commented Dec 12, 2016

fixed. You can do it in Transifex yourself ;) Please check in next daily.

@PVince81 PVince81 added this to the 9.1.4 milestone Dec 12, 2016

@michaelstingl

This comment has been minimized.

Show comment
Hide comment
@michaelstingl

michaelstingl Dec 16, 2016

{plural_s} seems to require some PHP magic. Just changing to {plural_n} in Transifex breaks it.

dateien_-_owncloud

michaelstingl commented Dec 16, 2016

{plural_s} seems to require some PHP magic. Just changing to {plural_n} in Transifex breaks it.

dateien_-_owncloud

DeepDiver1975 added a commit that referenced this issue Dec 19, 2016

Just use moment to comupte the time left for the upload - translation…
…s are delivered as part of moment.js - fixes #26804

@PVince81 PVince81 closed this in #26839 Dec 20, 2016

DeepDiver1975 added a commit that referenced this issue Dec 20, 2016

Just use moment to comupte the time left for the upload - translation…
…s are delivered as part of moment.js - fixes #26804
@luckydonald

This comment has been minimized.

Show comment
Hide comment
@luckydonald

luckydonald Dec 21, 2016

Contributor

Funfact: I'm german, but didn't see that coming while implementing back then.

Contributor

luckydonald commented Dec 21, 2016

Funfact: I'm german, but didn't see that coming while implementing back then.

@DeepDiver1975

This comment has been minimized.

Show comment
Hide comment
@DeepDiver1975

DeepDiver1975 Dec 21, 2016

Member

Funfact: I'm german, but didn't see that coming while implementing back then.

don't worry - we fixed it - still an awesome contribution!

THX @luckydonald

Member

DeepDiver1975 commented Dec 21, 2016

Funfact: I'm german, but didn't see that coming while implementing back then.

don't worry - we fixed it - still an awesome contribution!

THX @luckydonald

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment