Sharing autocomplete setting inconsistency #27224

Closed
PVince81 opened this Issue Feb 23, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@PVince81
Member

PVince81 commented Feb 23, 2017

The setting for sharing autocomplete defaults to disabled for emails here https://github.com/owncloud/core/blob/v9.1.4/core/ajax/share.php#L217

This was added through #26955.

If you go to the admin page you can see that the setting is enabled by default.
Also other pieces of code have it enabled by default, see https://github.com/owncloud/core/blob/v9.1.4/core/ajax/share.php#L360

This means that the email autocomplete will not work. To make it work you need to disable then enable it again in the admin page so that ownCloud creates an explicit setting in the DB.

@IljaN please change the default to "yes" in share.php to stay consistent.

@PVince81 PVince81 added this to the 9.1.5 milestone Feb 23, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Feb 23, 2017

Member

To be backported

Member

PVince81 commented Feb 23, 2017

To be backported

@PVince81 PVince81 referenced this issue Feb 23, 2017

Merged

Remove contact id in share with email code #27225

4 of 9 tasks complete

IljaN added a commit that referenced this issue Feb 27, 2017

@IljaN IljaN referenced this issue Feb 27, 2017

Merged

#27224 Sharing autocomplete inconsistency #27270

2 of 9 tasks complete

PVince81 added a commit that referenced this issue Mar 1, 2017

Merge pull request #27270 from owncloud/27224_sharing_autocomplete_se…
…tting_inconsistency


#27224 Sharing autocomplete inconsistency

IljaN added a commit that referenced this issue Mar 24, 2017

#27224 Sharing autocomplete inconsistency
(cherry picked from commit c227f29)

IljaN added a commit that referenced this issue Mar 24, 2017

#27224 Sharing autocomplete inconsistency
(cherry picked from commit c227f29)

IljaN added a commit that referenced this issue Mar 24, 2017

#27224 Sharing autocomplete inconsistency
(cherry picked from commit c227f29)

PVince81 added a commit that referenced this issue Mar 27, 2017

Merge pull request #27493 from owncloud/stable9.1-backport_sharing_au…
…tocomplete_inconsitency


#27224 Backport Stable 9.1 Sharing autocomplete inconsistency

PVince81 added a commit that referenced this issue Mar 27, 2017

Merge pull request #27496 from owncloud/stable8.2-sharing_autocomplet…
…e_inconsitency


#27224 Backport stable8.2 Sharing autocomplete inconsistency

@PVince81 PVince81 closed this Mar 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment