Shared dirs' listing #311

Closed
drablo opened this Issue Nov 7, 2012 · 27 comments

Projects

None yet
@drablo
drablo commented Nov 7, 2012

There is no listing of shared directories which may lead to leaks. Especially in case there are lots of users on servers which forget what they share and they would not tick the expiration date button.

@fmms
Contributor
fmms commented Nov 8, 2012

Thanks for reporting this. I think it is a very important feature.

@DeepDiver1975
Member

@MTGap Your opinion on this please. THX

@karlitschek
Member

An overview of items that someone shared is definitely a feature that we need for the future. Unfortunately not implemented yet.

@DeepDiver1975
Member

@karlitschek
Do you want to plan this for OC5? Who will be in charge?
@jancborchardt
You UX input is required here! THX

@karlitschek
Member

First we need a volunteer to do it. So currently unclear who and when. Also the question how important this is compared to the 100000 other feature requests ;-)

@DeepDiver1975
Member

Hehe - I'll mark it as a Junior Job to allow somebody to jump into ownCloud development.

@karlitschek
Member

good idea

@deHoeninger

The user localhost(owncloud forum)/libasys(github) already implemented such a function in his version. For sure it would be a good startingpoint.

http://forum.owncloud.org/viewtopic.php?f=3&t=4408 (see personal settings page @ the demo)

@LukasReschke
Member

Let's summon @libasys ;-)

@jancborchardt
Member

What we wanted to do for some time is permanently show the share status icon (globe or person) when a file is shared. Currently I’m also thinking if a sidebar for the files app would make sense, for:

  • Home
  • Recent

Then a section for everything shared:

  • (Studies)
  • (Logo sketches)
  • (…)

There would be no »trashbin«. This function, everything regarding undeletion of files earlier in the past, will be handled by #199 (status update page).

@drablo
drablo commented Nov 9, 2012

If I might add something to this; in some cases there are lots of files shared (when one for instance clicks to share a directory of subdirectories with thousands files). Having a list of shared files could result in a huge listing, which would substantially increase its loading time. There could be a pointer (an icon or something as jancborchardt suggests) by each file showing if it is shared or not. Another thing to consider would be a panel with links to directories shared in "settings" -> "personal" or alternatively another panel on the left side with "shared items". However, I'm not a programmer and I will rely upon you guys.

Thank you anyway for taking a look at it.

@mosch
mosch commented Nov 13, 2012

I think I want to try to contribute to ownCloud. And this might be a good feature to start. Already had a quick look into the code. I'll go into detail tonight and see if I may implement this.

@fmms
Contributor
fmms commented Nov 30, 2012

@mosch any update? Thanks for your work!

@laryllian

I would prefer just an additional column in the file view indicating the sharing status of each file, although a summary of shared files would be cool too. Especially with many subdirs and stuff. Thanks a lot ;-)

@jancborchardt
Member

(Carrying over discussion with @libasys from #810)

@libasys there is no problem, we pretty much agree except that the overview for shared files should be in the files app though (via toggle on the right of the top bar for instance), and not in personal settings. Would be cool if you can implement it and issue a pull request to files_sharing. cc @MTGap

@libasys
Contributor
libasys commented Dec 14, 2012

I know what you mean you have it implemented like the calendar app! For which version of OC should this feature implemented? OC 4.5 or OC5? I haven't a clean install for both version! All modified :) And the share api changed form OC4.5 to OC5.0! You have 1 wish free! ;)

@jancborchardt
Member

Going forward and a new feature, so ownCloud 5 I’d say.

@jedreg
jedreg commented Feb 1, 2013

Here is my $0.02. I could not find discussed feature so I developed very basic version of shared files and folders. If any of committers find it good enough, feel free to include it into git repo as it is already marked as AGPL. App can be downloaded from my blog --> http://amichalec.net/2013/02/owncloud-unsharing
-andy.

@jancborchardt
Member

@jedreg thanks for sharing!

Meanwhile, @MTGap fixed this problem in a very elegant and integrated way by just permanently displaying the »Shared« action item when a file is shared. Check it out in master or see the (already pulled in) pull request #1324

Hence closing this.

@jedreg
jedreg commented Feb 1, 2013

@jancborchardt, that sounds great, however #1324 does not solve the problem of "showing all my shares on any level of subfolders" as a shortcut to quick review what is exposed to others, right?
-andy.

@laryllian

The solution of @MTGap is nice, but unfortunately it does not scale beyond some folders with very few subfolders.

@tanghus
Member
tanghus commented Mar 18, 2013

I agree with @laryllian #1324 helps, but is not what people are asking for. Lets keep this open for all the dupes that asks for the functionality, and maybe someone will make an app for it.

@tanghus tanghus reopened this Mar 18, 2013
@MTGap
Contributor
MTGap commented Mar 18, 2013

It shouldn't be an app, it should be a filter for the files app.

@jancborchardt
Member

This will be addressed with the Files sidebar as in #1936. @laryllian @tanghus do you want to get into that and implement it?

@tanghus
Member
tanghus commented Mar 18, 2013

@jancborchardt I just didn't think this issue was closed for the right reason. Now #1936 has a plan we can refer to when the issue comes up again.

@laryllian

@jancborchardt Sorry to disappoint you, but I am not a programmer. I can conceptually help, but I wouldn't dare writing parts of a privacywise critical infrastructure such as oc.

@RealRancor
Contributor

Hi,

as a reference where this is implemented at the moment: #8417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment