Lost share when transferring files to recipient

[PVince81]

Steps

1. Create two users "user1" and "user2"
2. Login as "user1"
3. Create folder "foo/test"
4. Share "foo" with "user2"
5. Login as "user2"
6. Share the received "foo/test" with link
7. Log out
8. On the CLI: occ files:transfer-ownership user1 user2
9. Login as "user2"
10. Find the "test" folder in the "transferred from" folder
11. Check link share

Expected result

Link share preserved

Actual result

Link share completely lost, even removed from oc_share table.

Version

10.0.8 RC1

Discovered while testing #30161

[ownclouders]

GitMate.io thinks possibly related issues are #13671 (Versions lost when moving file into shared folder as recipient), #22594 (Meta data lost when recipient restores a file), #13307 (Move shared file into shared folder as recipient, moved share info lost), #16225 (Files_texteditor gets frozen when a user tries to open a shared file as recipient which was deleted), and #15468 (Files stop being shared after a recipient restores them to previous versions).

[PVince81]

setting to p2 as data loss is bad

[PVince81]

talked with @felixboehm and we're going to revert the original fix as the effect is less critical

then move ticket to 10.0.9 for a proper full fix

[PVince81]

Revert PR is here for stable10: #31164