Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP 7.3 #34464

Closed
csware opened this issue Feb 12, 2019 · 24 comments

Comments

Projects
None yet
@csware
Copy link

commented Feb 12, 2019

For ownCloud 10.0.10 support for PHP 7.2 was introduced and officially announced.

What about PHP 7.3?

I saw a commit aaf8c03 which seems to enable PHP 7.3, what about an official statement (e.g., on https://doc.owncloud.org/server/10.1/administration_manual/installation/system_requirements.html)?

Also requested here: https://central.owncloud.org/t/this-version-of-owncloud-is-not-compatible-with-php-7-3/17531

@ownclouders

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

GitMate.io thinks possibly related issues are #18791 (Stable 7 broken on php 5.3), #17783 (Prepare for PHP 7), #12606 ([master] Dropping PHP 5.3 support), #27570 (PHP 7.1 not supported error), and #12205 (PHP fatal error after upgrade to 7.0.3).

@DeepDiver1975

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

PM decision @pmaier1

@patrickjahns patrickjahns referenced this issue Feb 19, 2019

Merged

[stable10] support php7.3 #34559

1 of 11 tasks complete
@MacroMan

This comment has been minimized.

Copy link

commented Mar 4, 2019

Ubuntu 18.04 has started upgrading to php 7.3 as of today. New installs will also be 7.3.
If the new version of owncloud isn't going to be released very soon, you may wish to issue guidance on how to run with php 7.2 manually.

@scrobbleme

This comment has been minimized.

Copy link

commented May 9, 2019

Still not compatible...

@DeepDiver1975

This comment has been minimized.

Copy link
Member

commented May 9, 2019

php 7,3 support is in master - but not production ready. We require a release of sabre/dav 4.0.0 which did not happen up to now .... blame the sabre maintainers .....

@DeepDiver1975

This comment has been minimized.

Copy link
Member

commented May 9, 2019

blame the sabre maintainers .....

which is me - so just drop our complains in here 🤣

@patrickjahns

This comment has been minimized.

Copy link
Member

commented May 9, 2019

@MacroMan
I don't see Ubuntu 18.04 pushing for 7.3 packages yet ( https://packages.ubuntu.com/search?keywords=php&searchon=names&suite=bionic&section=all ). Where do you base your information on?

@scrobbleme
Would be great to have you onboard and push this topic forward :-) - I believe sabre maintainers need some help with testing. And we would need also some help with testing :-)

@MacroMan

This comment has been minimized.

Copy link

commented May 13, 2019

@patrickjahns I got my info from my server when apt upgraded PHP to 7.3
I had to downgrade and put a hold on the packages, which I still have, pending an Owncloud release (the only package I am now waiting for).

Can I ask why there is such a strict check on the PHP version? It was only a minor release with no breaking changes, wouldn't Owncloud function just fine?

@patrickjahns

This comment has been minimized.

Copy link
Member

commented May 13, 2019

@MacroMan
I don't see any official php7.3 packages in 18.04 LTS ( note I am only using stable/security repositories )

Can I ask why there is such a strict check on the PHP version? It was only a minor release with no breaking changes, wouldn't Owncloud function just fine?

See this PR: #34559 (comment)
There are currently upstream issues in sabredav library on php7.3 - we are waiting for the upstream library to be officially 7.3 compliant.

In order to ensure a stable platform, we are pushing forward to having every library/component we support fully 7.3 complaint and tested on php7.3 ;-)

@MacroMan

This comment has been minimized.

Copy link

commented May 13, 2019

My bad. I'm using the popular ondrej PPA: https://launchpad.net/~ondrej/+archive/ubuntu/php

@voinageo

This comment has been minimized.

Copy link

commented May 13, 2019

Fedora 30 was released last week. PHP 7.3 is the default and featured as one of the upgrades brought by Fedora 30.
Latest OwnCloud no longer works after upgrade to Fedora 30.

@patrickjahns

This comment has been minimized.

Copy link
Member

commented May 13, 2019

@voinageo
For supported distributions, please refer to our documentation https://doc.owncloud.com/server/admin_manual/installation/system_requirements.html

@voinageo

This comment has been minimized.

Copy link

commented May 13, 2019

Sadly a downgrade of Fedora 30 is not an option. The fast workaround was to apply by hand commit aaf8c03
It is just a hard check in console.php and index.php. For the stuff I use OwnCloud it seems OK, no issues using PHP 7.3

@mapkyca

This comment has been minimized.

Copy link

commented May 14, 2019

For the record, I just removed the upper version check in index.php. YMMV, and there's probably going to be something that fails, but seems to work fine for sync

@DeepDiver1975

This comment has been minimized.

Copy link
Member

commented May 14, 2019

YMMV, and there's probably going to be something that fails, but seems to work fine for sync

Good luck in killing your data. Seriously - we have such version checks there for a reason

@svde

This comment has been minimized.

Copy link

commented Jun 13, 2019

It would have been nice to include the version dependency in the OwnCloud rpm, which would prevent a Fedora system allowing the upgrade to an OS version with an incompatible php version.

It actually gets worse. a FC30 owncloud yum repo was created (see: https://download.owncloud.org/download/repositories/stable/owncloud/index.html) while the packages in that repo don't work with FC30, due to the php version shipped with FC30. A big fat warning should have been put on that page and the FC30 repo shouldn't have been created until it actually works.

@DeepDiver1975

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

@crrodriguez can you comment on these package requirements? Doable? THX

@robin13

This comment has been minimized.

Copy link

commented Jun 19, 2019

+1 on this. Just did apt upgrade on Debian 10 and got stuck with the default 7.3 PHP install which is not compatible with Owncloud 10.2.0.5 which was installed. It would be great if the .deb/.rpm packages would also have the dependency so that they cannot upgrade to a broken state.

@LinuxUser3

This comment has been minimized.

Copy link

commented Jun 19, 2019

+1 on this. I've installed OwnCloud and WordPress on same machine. And WordPress is alerting me to upgrade to PHP 7.3, but OwnCloud is blocking...

@fabrice-regnier

This comment has been minimized.

Copy link

commented Jun 24, 2019

@DeepDiver1975 please, tell us what could be done to help you to release OC with php7.3 or sabre or whatever.
regards,
f.

@DeepDiver1975

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

owncloud 10.3 will support php 7.3

@fabrice-regnier

This comment has been minimized.

Copy link

commented Jul 3, 2019

you @DeepDiver1975 rocks! thank you ;)

@DeepDiver1975

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

you @DeepDiver1975 rocks! thank you ;)

THX ... but it was a team effort ... I'll forward the greetings ;-)

@svde

This comment has been minimized.

Copy link

commented Jul 3, 2019

I'm so happy that you're cheering.

But... for the moment the "official" OwnCloud Fedora 30 repository remains BROKEN and UNTESTED. The RPM package still doesn't contain dependency information. People that upgrade to FC30 now still end up breaking OwnCloud.

Anyway, I've moved on (no longer using Owncloud).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.