Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Backport of Add re-login information after successful action #34596

Merged
merged 1 commit into from Feb 22, 2019

Conversation

sharidas
Copy link
Contributor

After the command is executed successfully by
recreating masterkey, the user should be informed
to relogin.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

Its always nice to provide information to the user after the command has done its job. Like if the users need to relogin or not. This change set helps to improve the information shared to user after the recreate masterkey command is successfully done. It tells all users must relogin.

Related Issue

  • Fixes <issue_link>

Motivation and Context

An information shared to users after successful execution of recreate masterkey command, i.e, to every user should relogin.

How Has This Been Tested?

  • Unit test.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

After the command is executed successfully by
recreating masterkey, the user should be informed
to relogin.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas
Copy link
Contributor Author

Original PR: owncloud/encryption#21

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #34596 into stable10 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34596      +/-   ##
==============================================
+ Coverage       63.99%   63.99%   +<.01%     
  Complexity      19223    19223              
==============================================
  Files            1272     1272              
  Lines           75716    75717       +1     
  Branches         1294     1294              
==============================================
+ Hits            48456    48457       +1     
  Misses          26879    26879              
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.28% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.14% <100%> (ø) 19223 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/encryption/lib/Command/RecreateMasterKey.php 86.07% <100%> (+0.17%) 10 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 629b43e...5a4664c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #34596 into stable10 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34596      +/-   ##
==============================================
+ Coverage       63.99%   63.99%   +<.01%     
  Complexity      19223    19223              
==============================================
  Files            1272     1272              
  Lines           75716    75717       +1     
  Branches         1294     1294              
==============================================
+ Hits            48456    48457       +1     
  Misses          26879    26879              
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.28% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.14% <100%> (ø) 19223 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/encryption/lib/Command/RecreateMasterKey.php 86.07% <100%> (+0.17%) 10 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 629b43e...5a4664c. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 57d20eb into stable10 Feb 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the relogin-info-recreate-masterkey-stable10 branch February 22, 2019 21:10
@PVince81 PVince81 modified the milestones: development, QA Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants