Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] First time login was not properly handled by \OC\User\Sess… #34758

Merged

Conversation

DeepDiver1975
Copy link
Member

backport #34736

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #34758 into stable10 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34758      +/-   ##
==============================================
- Coverage       64.19%   64.19%   -0.01%     
  Complexity      19887    19887              
==============================================
  Files            1278     1278              
  Lines           76245    76245              
  Branches         1291     1291              
==============================================
- Hits            48947    48946       -1     
- Misses          26919    26920       +1     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.35% <100%> (-0.01%) 19887 <5> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/User/Session.php 79.47% <100%> (ø) 153 <5> (ø) ⬇️
lib/private/Server.php 86.53% <0%> (-0.12%) 253% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700efa1...8ded0b1. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit 97930e5 into stable10 Mar 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-cda98b673bf2bc45950d65849cb9ff612c9d7e17 branch March 13, 2019 15:26
@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants