Breaking change: 10.2 changes avatars location

[j-snd]

Hi,
after upgrading with Debian package manager from 10.1 to 10.2 all avatars have gone. I have upgraded two different servers and avatars disappeared at both.

Operating system:
Debian Linux Stretch 9.9
Web server:
Apache Version 2.4.25
Database:
mysql 14.14 Distrib 5.6.30
PHP version:
PHP 7.0.33-0+deb9u3
ownCloud version: (see ownCloud admin page)
10.2.0 (stable)
Updated from an older ownCloud or fresh install:
10.1.1 (stable)
Where did you install ownCloud from:
deb http://download.owncloud.org/download/repositories/production/Debian_9.0/ /

Regards
Jochen

[davitol]

@j-snd Thanks for reporting. Were the avatars hosted in an LDAP server or they were regular users

[j-snd]

The avatars were from regular users. In the meantime I have upgraded another server by installing the tarball and all avatars are removed too. Did no one else had this problem? Is there a way to restore the avatars without going back to the previous version of owncloud?

[davitol]

Just tested with a tarball too and I was able to reproduce it too. The info of the avatars persists in the backend but they are not shown in the webUI

[micbar]

could be related to owncloud/enterprise#3332

[wassereimer86]

I upgraded from 10.0.2 to 10.2.0 manually and have the same problem. The Data folder is not in the installation direrctory and the avatars are still there. They are regular users. php 7.1.

If i upload a new avatar it´s not located in the avatars folder. So the path seems to be messed up.
Before: datafolder/avatars/xx/...
After: datafolder/xx/...

[VicDeo]

most likely broken with 18dc418

[VicDeo]

yep, checkout to f5ae32e changes the behavior.
#34592 introduces that

[VicDeo]

@micbar FYI: 10.2 pollutes data folder on avatar upload.

[micbar]

@micbar FYI: 10.2 pollute data folder on avatar upload.

@cdamken @pako81 @voroyam
Could be that you see avatars wrongly uploaded in customers data/ folders instead of data/avatars/

[VicDeo]

the fix for this issue is oneliner but we might need a repair step now to collect the garbage directories. :/

[VicDeo]

@j-snd could you try the change from #35363 ?

[j-snd]

Hi VicDeo, I have changed Avatar.php and all missing avatars show up again. Was it this what I should try?

[micbar]

@VicDeo Do you think the repair step is really necessary?

@pmaier1

[wassereimer86]

If someone uploaded a new Avatar because the one befor was gone: Is it there after the update without a repair? Or does the User again have no Avatar? That´s the question which should answer the one above me.

[VicDeo]

@micbar old location is a subdir of data/avatars. md5 of uid with chars 1-2 and 3-4 treated as directory names
e.g if md5(uid) is 16fdfa8f744211bb1f44be3042e5ebeb the avatar will be stored under
data/avatars/16/fd/fa8f744211bb1f44be3042e5ebeb/
for 10.2 it is just data/16/fd/fa8f744211bb1f44be3042e5ebeb/

1. everybody started with 10.2 will have the same issue with 10.3 because the fix reverts new avatar location to the old one
2. data folder will have stray avatar directories like 16 in the example above as the new location is not unified

[pmaier1]

@VicDeo Do you think the repair step is really necessary?

Well, we should clean this up properly, yes.

[pmaier1]

PR for release notes known issue owncloud/docs#1294