Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatenotification app should consider upgrade.disable-web config value #35810

Open
cortho opened this issue Jul 11, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@cortho
Copy link

commented Jul 11, 2019

User cs35 found out at https://central.owncloud.org/t/owncloud-upgrade-disable-web-working/20912 that when upgrade.disable-web is set to true in config.php the app still offers an update via web in the admin settings.

My guts say when an admin configures this value, no web updater should be active.

@cortho cortho changed the title updatenotification should consider upgrade.disable-web config value updatenotification app should consider upgrade.disable-web config value Jul 11, 2019

@phil-davis

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

"when upgrade.disable-web is set to false"
don't you mean:
"when upgrade.disable-web is set to true" ?

@cs35-owncloud

This comment has been minimized.

Copy link

commented Jul 11, 2019

@phil-davis Hello indeed you're right, when you set upgrade.disable-web to true it displays the updater and should not.

@cortho

This comment has been minimized.

Copy link
Author

commented Jul 12, 2019

Yes, I mixed it up. "when upgrade.disable-web is set to true" - fixed it in the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.